Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker profiles to simplify compose file #189

Closed
wpfl-dbt opened this issue Apr 8, 2024 · 2 comments
Closed

Use docker profiles to simplify compose file #189

wpfl-dbt opened this issue Apr 8, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@wpfl-dbt
Copy link
Contributor

wpfl-dbt commented Apr 8, 2024

The docker compose file is quite confusing and unintuitive. We can use profiles to make the compose explicitly group services to match they way the dev team are mentally grouping them. This will also make integration testing easier, as the function of the groups is abstracted away from the services that actually make it up.

I suggest broad groups of backend and frontend_*, for example:

docker compose --profile backend --profile frontend_streamlit up
docker compose --profile backend --profile frontend_django up
@gecBurton
Copy link
Collaborator

@wpfl-dbt thank you for raising this, we will discuss at sprint planning on the 2024/04/10

@lmwilkigov lmwilkigov added the enhancement New feature or request label Apr 11, 2024
@wpfl-dbt
Copy link
Contributor Author

wpfl-dbt commented Jul 5, 2024

Solved by instead configuring dependency trees.

@wpfl-dbt wpfl-dbt closed this as completed Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants