Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daily processing pipeline #405

Open
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

nicHoch
Copy link
Collaborator

@nicHoch nicHoch commented Oct 17, 2024

create a second processing pipeline to handle not TM packets triggered processing steps

this pipeline runs on a cron bases (once a day?) and performs product creations (fits files)

first included processing is HK-L+ to ANC-ASPECT files

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 17.35905% with 557 lines in your changes missing coverage. Please review.

Project coverage is 71.21%. Comparing base (ae330f3) to head (fff77d1).

Files with missing lines Patch % Lines
stixcore/processing/pipeline_daily.py 0.00% 133 Missing ⚠️
stixcore/processing/SingleStep.py 30.25% 83 Missing ⚠️
stixcore/processing/AspectANC.py 0.00% 81 Missing ⚠️
stixcore/io/FlareListManager.py 0.00% 69 Missing ⚠️
stixcore/processing/FLtoL3.py 0.00% 66 Missing ⚠️
stixcore/products/ANC/aspect.py 37.07% 56 Missing ⚠️
stixcore/io/ProcessingHistoryStorage.py 0.00% 53 Missing ⚠️
stixcore/io/fits/processors.py 28.57% 10 Missing ⚠️
stixcore/ephemeris/manager.py 88.88% 3 Missing ⚠️
stixcore/processing/publish.py 81.25% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
- Coverage   75.84%   71.21%   -4.64%     
==========================================
  Files          68       75       +7     
  Lines        7257     7795     +538     
==========================================
+ Hits         5504     5551      +47     
- Misses       1753     2244     +491     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@samaloney samaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

I'm concerned about out use of context mangers and multiple threads - I don't think they are natively thread aware. Might not be an issue for this PR but brought to my attention based on our conversation the other day and this PR

stixcore/io/ProcessingHistoryStorage.py Show resolved Hide resolved
stixcore/io/FlareListManager.py Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
@samaloney
Copy link
Collaborator

Also I see the tests are failing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants