Sourcemaps incorrect line number

[paradox37]

Describe the bug

As soon as I add this plugin to vite config, I get the wrong line number in browser Console in case of console.log or when unexpected error occurs, which is affecting debugging pretty much.

I expect this plugin to does not affect sourcemaps in a way that points to a wrong line. You can see this behavior in stackblitz I provided. I used stackblitz template preset from ViteJs site, and just added this plugin and one console.log.

Also, take a look at screen shot. Console says line 14, but it's actually 7.

Reproduction

https://stackblitz.com/edit/vitejs-vite-hcnpyq?terminal=dev

Steps to reproduce

• Open stackblitz.
• Check browser Console
• Click on the App.tsx:14
• It goes to line 14 instead of 7.

System Info

Any system, any browser

Used Package Manager

npm

Logs

No response

Validations

• Read the Contributing Guidelines.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a vite-plugin-istanbul issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• The provided reproduction is a minimal reproducible example of the bug.

[iFaxity]

Hi @paradox37, big thanks for the issue.

I'll take a look at this and see what I can come up with.

The issue i feel might be that there is something that the underlying instrumenter is doing wrong (official istanbul-lib-instrument). As it is using babel to analyse the code it might affect the sourcemap as we use the returned sourcemap to match the coverage to the sourcemap.

Thanks!

[kota65535]

Same here. Is there any progress?

[github-actions]

🎉 This issue has been resolved in version 5.0.0-rc.1 🎉

The release is available on:

• npm package (@next dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[iFaxity]

Please try out the new version to see if the fix is working in the pre release. And i will plan a stable release if it gets good responses.