Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official station names vs. alternatives #13

Open
jncn opened this issue Apr 5, 2015 · 5 comments
Open

Official station names vs. alternatives #13

jncn opened this issue Apr 5, 2015 · 5 comments

Comments

@jncn
Copy link
Contributor

jncn commented Apr 5, 2015

How do we handle official names and their alternatives?
e.g. Brussel-Nationaal-Luchthaven vs. Brussels-Airport or Amsterdam CS (old name) vs. Amsterdam Centraal (official name).

@pietercolpaert
Copy link
Member

That's a good question. This is where our CSV model gets a bit too limited. If we add 1 alternative, the alternative should also be translated, right?

Should we change our repository to use JSON instead?

@pietercolpaert
Copy link
Member

As I've understood from our conversation at https://gitter.im/iRail/iRail, you're using this repo to load the stations inside SQLite. I think therefore keeping our CSV table as is is a good idea.

Another possible solution would be to add yet an extra column for autocomplete purposes: alternative-1 alternative-2 ...

What do you think?

@brechtvdv
Copy link
Contributor

I don't think adding extra columns for alternatives is feasible.. See also: iRail/iRail#68

@brechtvdv
Copy link
Contributor

I suggest we add an extra csv-file with two columns: alternative-name and official name. Much easier to maintain

@pietercolpaert
Copy link
Member

Right now our kind of organically grown method is to hardcode them in our "autocomplete" code in PHP: https://github.com/iRail/stations/blob/master/src/irail/stations/Stations.php#L33

For instance, we could also add that everything that's "CS" is replaced with "centraal"?

Of course this doesn't help other programming languages...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants