Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LocaleData: weekdays is not a function on instance level #1017

Closed
Phil147 opened this issue Aug 20, 2020 · 2 comments · Fixed by #1019
Closed

LocaleData: weekdays is not a function on instance level #1017

Phil147 opened this issue Aug 20, 2020 · 2 comments · Fixed by #1019
Labels
released

Comments

@Phil147
Copy link

Phil147 commented Aug 20, 2020 •
edited
Loading

Describe the bug
When using localeData from an instance the error weekdays is not a function is thrown.

Steps to reproduce:

dayjs().localeData().weekdays()

Using the global function it works:

dayjs.localeData().weekdays()

Expected behavior
localeData returns the same objects for local and global calls.

It is also documented that way: https://day.js.org/docs/en/plugin/locale-data

Information

  • Day.js Version 1.8.34
iamkun added a commit that referenced this issue Aug 21, 2020
@iamkun
fix: fix LocaleData plugin to support instance.weekdays() API
da51865 
fix #1017
@iamkun iamkun mentioned this issue Aug 21, 2020
Merged
@iamkun
Copy link
Owner

iamkun commented Aug 21, 2020

Thanks. Fixed in #1019

iamkun added a commit that referenced this issue Aug 22, 2020
@iamkun
fix: fix LocaleData plugin to support instance.weekdays() API (#1019)
a09d259 
fix #1017
iamkun pushed a commit that referenced this issue Sep 2, 2020
@semantic-release-bot
chore(release): 1.8.35 [skip ci]
82b5034 
## [1.8.35](v1.8.34...v1.8.35) (2020-09-02)

### Bug Fixes

* Fix BadMutable plugin bug in .diff ([#1023](#1023)) ([40ab6d9](40ab6d9))
* fix LocaleData plugin to support instance.weekdays() API ([#1019](#1019)) ([a09d259](a09d259)), closes [#1017](#1017)
* Update Dutch (nl) locale to set correct yearStart ([1533a2c](1533a2c))
@iamkun
Copy link
Owner

iamkun commented Sep 2, 2020

🎉 This issue has been resolved in version 1.8.35 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamkun iamkun added the released label Sep 2, 2020
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this issue May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.35 [skip ci]
0bb9941 
## [1.8.35](iamkun/dayjs@v1.8.34...v1.8.35) (2020-09-02)

### Bug Fixes

* Fix BadMutable plugin bug in .diff ([#1023](iamkun/dayjs#1023)) ([40ab6d9](iamkun/dayjs@40ab6d9))
* fix LocaleData plugin to support instance.weekdays() API ([#1019](iamkun/dayjs#1019)) ([a09d259](iamkun/dayjs@a09d259)), closes [#1017](iamkun/dayjs#1017)
* Update Dutch (nl) locale to set correct yearStart ([1533a2c](iamkun/dayjs@1533a2c))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this issue May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.35 [skip ci]
85c2b7c 
## [1.8.35](iamkun/dayjs@v1.8.34...v1.8.35) (2020-09-02)

### Bug Fixes

* Fix BadMutable plugin bug in .diff ([#1023](iamkun/dayjs#1023)) ([40ab6d9](iamkun/dayjs@40ab6d9))
* fix LocaleData plugin to support instance.weekdays() API ([#1019](iamkun/dayjs#1019)) ([a09d259](iamkun/dayjs@a09d259)), closes [#1017](iamkun/dayjs#1017)
* Update Dutch (nl) locale to set correct yearStart ([1533a2c](iamkun/dayjs@1533a2c))
splashwizard pushed a commit to splashwizard/tracking-time that referenced this issue Oct 21, 2024
@semantic-release-bot
chore(release): 1.8.35 [skip ci]
56d957e 
## [1.8.35](iamkun/dayjs@v1.8.34...v1.8.35) (2020-09-02)

### Bug Fixes

* Fix BadMutable plugin bug in .diff ([#1023](iamkun/dayjs#1023)) ([40ab6d9](iamkun/dayjs@40ab6d9))
* fix LocaleData plugin to support instance.weekdays() API ([#1019](iamkun/dayjs#1019)) ([a09d259](iamkun/dayjs@a09d259)), closes [#1017](iamkun/dayjs#1017)
* Update Dutch (nl) locale to set correct yearStart ([1533a2c](iamkun/dayjs@1533a2c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix LocaleData plugin to support instance.weekdays() API iamkun/dayjs
2 participants
@Phil147 @iamkun