Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meridiem in ar language #1282

Closed
hazemmadkour opened this issue Dec 20, 2020 · 1 comment · Fixed by #1375
Closed

meridiem in ar language #1282

hazemmadkour opened this issue Dec 20, 2020 · 1 comment · Fixed by #1375
Labels
enhancement New feature or request good first issue Good for newcomers released

Comments

@hazemmadkour
Copy link

hazemmadkour commented Dec 20, 2020 •
edited
Loading

When i format date/time in arabic i get this "الأحد, ديسمبر 20, 2020 7:29 AM", while AM and PM is not translated in arabic. i will ad the fix here as im not familiar with contributing with bug fix

meridiem: (hour, minute, isLowercase) => { return hour > 12 ? 'م' : 'ص' }

also i hope you add localization for ar-eg
@iamkun iamkun added enhancement New feature or request good first issue Good for newcomers labels Jan 3, 2021
@sangxxh sangxxh mentioned this issue Feb 8, 2021
Merged
@iamkun
Copy link
Owner

iamkun commented May 26, 2021

🎉 This issue has been resolved in version 1.10.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(locale): add meridiem in ar languages
2 participants
@iamkun @hazemmadkour