fix: narrow type for `add` and `subtract` #1576

susiwen8 · 2021-07-13T16:06:05Z

addisonElliott · 2021-07-13T16:40:47Z

Your fix removes the UnitTypeLongPlural type. So any pluralized types would return errors now. Looking at the code, it also applies to diff() function. Not only that, this doesn't remove the dates plural type.

However, I wonder if it would be better to add support for date in add/subtract/diff. It would be relatively easy and make it consistent with startOf, endOf functions.

FYI, if you use dayjs.add(1, 'date'), it will add 1ms to the date. See here: https://github.com/iamkun/dayjs/blob/dev/src/index.js#L243

If the date keyword is not going to be supported for add/subtract/, I recommend just omitting the date & dates types from the OpUnitType itself.

type OpUnitType2 = Omit<OpUnitType, 'date' | 'dates'>;

susiwen8 · 2021-07-14T01:19:57Z

@addisonElliott Thanks,

So any pluralized types would return errors now.

Indeed pluralized type should be included.

if you use dayjs.add(1, 'date'), it will add 1ms to the date

You are right, I tried myself, date act like ms

I wonder if it would be better to add support for date in add/subtract/diff

Agree, I was going to fix this way. But I thought this might be intentional or someting that left date behind

codecov · 2021-07-14T14:45:24Z

Codecov Report

Merging #1576 (bf7c478) into dev (5a79cc6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               dev     #1576   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          177       177           
  Lines         1989      1989           
  Branches       505       505           
=========================================
  Hits          1989      1989

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a79cc6...bf7c478. Read the comment docs.

iamkun · 2021-07-30T12:47:46Z

Yes, date should not be supported in dayjs.add, cause add a date make no sense

susiwen8 · 2021-07-30T12:49:37Z

@iamkun should I reopen this PR?

iamkun · 2021-07-30T12:49:54Z

why not 😁

susiwen8 · 2021-07-30T12:51:07Z

@iamkun please review 😁

iamkun · 2021-07-30T12:54:27Z

BTW, is any special reason to close it?

susiwen8 · 2021-07-30T13:06:15Z

Just thought you might not interested in this pr.

iamkun · 2021-07-31T03:22:35Z

@addisonElliott according to moment.js date is not support as well.

let's just omit it

https://momentjs.com/docs/#/manipulating/add/

## [1.10.7](v1.10.6...v1.10.7) (2021-09-10) ### Bug Fixes * Add Spanish (Mexico) [es-mx] locale ([#1614](#1614)) ([3393f2a](3393f2a)) * Add Arabic (Iraq) [ar-iq] locale ([#1627](#1627)) ([b5a1391](b5a1391)) * add format object type to type file ([#1572](#1572)) ([5a79cc6](5a79cc6)) * duration plugin when parsing duration from ISO string, set missing components to 0 instead of NaN ([#1611](#1611)) ([252585b](252585b)) * narrow type for `add` and `subtract` ([#1576](#1576)) ([1686962](1686962)) * update customParseFormat plugin strict x X parsing ([#1571](#1571)) ([08adda5](08adda5)) * update Lithuanian [lt] locale spelling for single month ([#1609](#1609)) ([255dc54](255dc54)) * Update Norwegian Bokmål [nb] local yearStart 4 ([#1608](#1608)) ([7a8467c](7a8467c)) * update plugin advancedFormat `isValid` validation ([#1566](#1566)) ([755fc8b](755fc8b)) * update Sinhalese [si] locale month name ([#1475](#1475)) ([63de2a8](63de2a8)) * update utcOffset plugin type file ([#1604](#1604)) ([f68e4b1](f68e4b1))

iamkun · 2021-09-10T09:34:47Z

🎉 This PR is included in version 1.10.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

## [1.10.7](iamkun/dayjs@v1.10.6...v1.10.7) (2021-09-10) ### Bug Fixes * Add Spanish (Mexico) [es-mx] locale ([#1614](iamkun/dayjs#1614)) ([3393f2a](iamkun/dayjs@3393f2a)) * Add Arabic (Iraq) [ar-iq] locale ([#1627](iamkun/dayjs#1627)) ([b5a1391](iamkun/dayjs@b5a1391)) * add format object type to type file ([#1572](iamkun/dayjs#1572)) ([5a79cc6](iamkun/dayjs@5a79cc6)) * duration plugin when parsing duration from ISO string, set missing components to 0 instead of NaN ([#1611](iamkun/dayjs#1611)) ([252585b](iamkun/dayjs@252585b)) * narrow type for `add` and `subtract` ([#1576](iamkun/dayjs#1576)) ([1686962](iamkun/dayjs@1686962)) * update customParseFormat plugin strict x X parsing ([#1571](iamkun/dayjs#1571)) ([08adda5](iamkun/dayjs@08adda5)) * update Lithuanian [lt] locale spelling for single month ([#1609](iamkun/dayjs#1609)) ([255dc54](iamkun/dayjs@255dc54)) * Update Norwegian Bokmål [nb] local yearStart 4 ([#1608](iamkun/dayjs#1608)) ([7a8467c](iamkun/dayjs@7a8467c)) * update plugin advancedFormat `isValid` validation ([#1566](iamkun/dayjs#1566)) ([755fc8b](iamkun/dayjs@755fc8b)) * update Sinhalese [si] locale month name ([#1475](iamkun/dayjs#1475)) ([63de2a8](iamkun/dayjs@63de2a8)) * update utcOffset plugin type file ([#1604](iamkun/dayjs#1604)) ([f68e4b1](iamkun/dayjs@f68e4b1))

## [1.10.7](iamkun/dayjs@v1.10.6...v1.10.7) (2021-09-10) ### Bug Fixes * Add Spanish (Mexico) [es-mx] locale ([#1614](iamkun/dayjs#1614)) ([3393f2a](iamkun/dayjs@3393f2a)) * Add Arabic (Iraq) [ar-iq] locale ([#1627](iamkun/dayjs#1627)) ([b5a1391](iamkun/dayjs@b5a1391)) * add format object type to type file ([#1572](iamkun/dayjs#1572)) ([5a79cc6](iamkun/dayjs@5a79cc6)) * duration plugin when parsing duration from ISO string, set missing components to 0 instead of NaN ([#1611](iamkun/dayjs#1611)) ([252585b](iamkun/dayjs@252585b)) * narrow type for `add` and `subtract` ([#1576](iamkun/dayjs#1576)) ([1686962](iamkun/dayjs@1686962)) * update customParseFormat plugin strict x X parsing ([#1571](iamkun/dayjs#1571)) ([08adda5](iamkun/dayjs@08adda5)) * update Lithuanian [lt] locale spelling for single month ([#1609](iamkun/dayjs#1609)) ([255dc54](iamkun/dayjs@255dc54)) * Update Norwegian Bokmål [nb] local yearStart 4 ([#1608](iamkun/dayjs#1608)) ([7a8467c](iamkun/dayjs@7a8467c)) * update plugin advancedFormat `isValid` validation ([#1566](iamkun/dayjs#1566)) ([755fc8b](iamkun/dayjs@755fc8b)) * update Sinhalese [si] locale month name ([#1475](iamkun/dayjs#1475)) ([63de2a8](iamkun/dayjs@63de2a8)) * update utcOffset plugin type file ([#1604](iamkun/dayjs#1604)) ([f68e4b1](iamkun/dayjs@f68e4b1))

fix: narrow type for add and subtract

5138e07

chore: enhace type

bf7c478

susiwen8 closed this Jul 30, 2021

susiwen8 reopened this Jul 30, 2021

iamkun merged commit 1686962 into iamkun:dev Jul 31, 2021

iamkun added the released label Sep 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: narrow type for `add` and `subtract` #1576

fix: narrow type for `add` and `subtract` #1576

susiwen8 commented Jul 13, 2021

addisonElliott commented Jul 13, 2021 •

edited

Loading

susiwen8 commented Jul 14, 2021 •

edited

Loading

codecov bot commented Jul 14, 2021 •

edited

Loading

iamkun commented Jul 30, 2021

susiwen8 commented Jul 30, 2021

iamkun commented Jul 30, 2021

susiwen8 commented Jul 30, 2021

iamkun commented Jul 30, 2021

susiwen8 commented Jul 30, 2021

iamkun commented Jul 31, 2021

iamkun commented Sep 10, 2021

fix: narrow type for add and subtract #1576

fix: narrow type for add and subtract #1576

Conversation

susiwen8 commented Jul 13, 2021

addisonElliott commented Jul 13, 2021 • edited Loading

susiwen8 commented Jul 14, 2021 • edited Loading

codecov bot commented Jul 14, 2021 • edited Loading

Codecov Report

iamkun commented Jul 30, 2021

susiwen8 commented Jul 30, 2021

iamkun commented Jul 30, 2021

susiwen8 commented Jul 30, 2021

iamkun commented Jul 30, 2021

susiwen8 commented Jul 30, 2021

iamkun commented Jul 31, 2021

iamkun commented Sep 10, 2021

fix: narrow type for `add` and `subtract` #1576

fix: narrow type for `add` and `subtract` #1576

addisonElliott commented Jul 13, 2021 •

edited

Loading

susiwen8 commented Jul 14, 2021 •

edited

Loading

codecov bot commented Jul 14, 2021 •

edited

Loading