Fix issue #1852 - comma not recognized as a separator character #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## [1.11.2](iamkun/dayjs@v1.11.1...v1.11.2) (2022-05-06) ### Bug Fixes * add OpUnitType (week) to quarterOfYear startOf/endOf types ([iamkun#1865](iamkun#1865)) ([400bc3e](iamkun@400bc3e)) * Fix type issue with ManipulateType ([iamkun#1864](iamkun#1864)) ([d033dfc](iamkun@d033dfc)) * fix UTC plugin .valueOf not taking DST into account ([iamkun#1448](iamkun#1448)) ([27d1c50](iamkun@27d1c50))
Dash could be misinterpreted as range operator.
In 'formatTokens' dash is not recognized as a word separator, but in 'matchWord' it is.
This was referenced May 29, 2022
|
Thanks. We should |
|
🎉 This PR is included in version 1.11.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
iamkun
pushed a commit
that referenced
this pull request
Jun 11, 2022
This was referenced Jul 27, 2024
This was referenced Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comma is a very common word separator used in dates with short or long month names (see issue #1852); so it should be part of the characters, recognized as word separators.
When fixing this issue, I noticed that the characters used as word separators in 'formattingTokens' (split format string into tokens) and 'matchWord' (find separators between date parts) differ: the underscore was missing in 'formattingTokens' - fixed that too.