-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't input negative years #2636
Comments
I know this is potentially not easy given the Julian/Gregorian change, but it would be very useful! |
HI @willismonroe ,
Is this enough for you? Do you have any other use cases you'd like to test? |
Sorry @klm-turing were you showing the output of a proposed fix? If so, that's great. No other issues I'd like to test at the moment, as I mentioned earlier there are quite a few edge cases extra that would be worth looking into, but even just having negative years is a huge improvement. |
@willismonroe I wanted to know if it was enough for you first. I linked a PR 2640. Test it and let me know |
Maybe it will be better to be implemented via a plugin. |
@iamkun nice touch, I will do that |
@iamkun The plugin is done, If you have time, Please have a look. |
Describe the bug
I'm trying to work with negative years in a mermaid-js gantt chart but tracing down their date parsing lead me to dayjs. Right now I can get a negative year to display by subtracting years from a positive year date, but there seems to be no way to parse a negative year from the outset.
Expected behavior
I would like to be able to enter
dayjs('-2600')
and get (NB I don't know if it's a friday) Fri, 01 Jan -2600 00:00:00 GMT.Information
The text was updated successfully, but these errors were encountered: