-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(format): reuse matches instead of created when replacing #441
Conversation
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 54 54
Lines 481 482 +1
Branches 75 75
=====================================
+ Hits 481 482 +1
Continue to review full report at Codecov.
|
Using benchmarking configuration that @prantlf done at #344, these are the results before and after aplying the suggested changes
There are some improvement, so it seems that this is good to go 😀 |
## [1.8.1](v1.8.0...v1.8.1) (2019-02-02) ### Performance Improvements * **format:** reuse matches instead of created when replacing ([#441](#441)) ([10b79d8](10b79d8))
🎉 This PR is included in version 1.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [1.8.1](iamkun/dayjs@v1.8.0...v1.8.1) (2019-02-02) ### Performance Improvements * **format:** reuse matches instead of created when replacing ([#441](iamkun/dayjs#441)) ([10b79d8](iamkun/dayjs@10b79d8))
## [1.8.1](iamkun/dayjs@v1.8.0...v1.8.1) (2019-02-02) ### Performance Improvements * **format:** reuse matches instead of created when replacing ([#441](iamkun/dayjs#441)) ([10b79d8](iamkun/dayjs@10b79d8))
## [1.8.1](iamkun/dayjs@v1.8.0...v1.8.1) (2019-02-02) ### Performance Improvements * **format:** reuse matches instead of created when replacing ([#441](iamkun/dayjs#441)) ([10b79d8](iamkun/dayjs@10b79d8))
as title saying. @iamkun