Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid Thai translation on "fromNow" function when 1 day passed #816

Closed
ReiiYuki opened this issue Mar 5, 2020 · 2 comments · Fixed by #826 or BlueWallet/BlueWallet#961 · May be fixed by cds-snc/apply-for-a-grant#32
Closed

Invalid Thai translation on "fromNow" function when 1 day passed #816

ReiiYuki opened this issue Mar 5, 2020 · 2 comments · Fixed by #826 or BlueWallet/BlueWallet#961 · May be fixed by cds-snc/apply-for-a-grant#32
Labels
released

Comments

@ReiiYuki
Copy link

ReiiYuki commented Mar 5, 2020

Describe the bug
A clear and concise description of what the bug is.

Invalid result when i apply with one day passed

Current result is วัน ที่ผ่านมา

Expected behavior
A clear and concise description of what you expected to happen.

It should be 1 วัน ที่ผ่านมา

Information

  • Day.js Version 1.8.21
  • OS: OSX
  • Browser Chrome 80.0.3987.122
  • Time zone: GMT+07:00 (Indochina Time)
@iamkun
Copy link
Owner

iamkun commented Mar 5, 2020 •
edited
Loading

Thanks.

Could you please send us a pull request to correct this in "Thai" (cause we don't know this language.)

This's easy, just to keep sync between
https://github.com/iamkun/dayjs/blob/dev/src/locale/th.js#L19
and
https://github.com/moment/moment/blob/develop/locale/th.js#L46
relativeTime section, and ignore the ss one.

Cheers.

@iamkun iamkun added the ☢️Bug Something isn't working label Mar 5, 2020
iamkun added a commit that referenced this issue Mar 9, 2020
@iamkun
fix: Update Thai (th) locale relativeTime
2399d8e 
fix #816
@iamkun iamkun mentioned this issue Mar 9, 2020
Merged
iamkun added a commit that referenced this issue Mar 9, 2020
@iamkun
fix: Update Thai (th) locale relativeTime (#826)
63b7c03 
fix #816
@iamkun iamkun removed the ☢️Bug Something isn't working label Mar 9, 2020
iamkun pushed a commit that referenced this issue Mar 16, 2020
@semantic-release-bot
chore(release): 1.8.23 [skip ci]
90eae15 
## [1.8.23](v1.8.22...v1.8.23) (2020-03-16)

### Bug Fixes

* Add Chinese (zh) locale ([f9b8945](f9b8945))
* Fix IsoWeek plugin typescript definition ([#828](#828)) ([30aab0c](30aab0c))
* Update Arabic (ar) locale relative time ([#836](#836)) ([14044c6](14044c6))
* Update Slovak (sk) locale,  Czech (cs) locale ([#833](#833)) ([f0d451f](f0d451f))
* Update Thai (th) locale relativeTime ([#826](#826)) ([63b7c03](63b7c03)), closes [#816](#816)
@iamkun
Copy link
Owner

iamkun commented Mar 16, 2020

🎉 This issue has been resolved in version 1.8.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

epszaw pushed a commit to epszaw/dayjs that referenced this issue Apr 7, 2020
@semantic-release-bot
chore(release): 1.8.23 [skip ci]
7e2dcc0 
## [1.8.23](iamkun/dayjs@v1.8.22...v1.8.23) (2020-03-16)

### Bug Fixes

* Add Chinese (zh) locale ([f9b8945](iamkun@f9b8945))
* Fix IsoWeek plugin typescript definition ([iamkun#828](iamkun#828)) ([30aab0c](iamkun@30aab0c))
* Update Arabic (ar) locale relative time ([iamkun#836](iamkun#836)) ([14044c6](iamkun@14044c6))
* Update Slovak (sk) locale,  Czech (cs) locale ([iamkun#833](iamkun#833)) ([f0d451f](iamkun@f0d451f))
* Update Thai (th) locale relativeTime ([iamkun#826](iamkun#826)) ([63b7c03](iamkun@63b7c03)), closes [iamkun#816](iamkun#816)
This was referenced Apr 8, 2020
Merged
Open
@snyk-bot snyk-bot mentioned this issue May 3, 2020
Closed
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this issue May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.23 [skip ci]
953a5c4 
## [1.8.23](iamkun/dayjs@v1.8.22...v1.8.23) (2020-03-16)

### Bug Fixes

* Add Chinese (zh) locale ([f9b8945](iamkun/dayjs@f9b8945))
* Fix IsoWeek plugin typescript definition ([#828](iamkun/dayjs#828)) ([30aab0c](iamkun/dayjs@30aab0c))
* Update Arabic (ar) locale relative time ([#836](iamkun/dayjs#836)) ([14044c6](iamkun/dayjs@14044c6))
* Update Slovak (sk) locale,  Czech (cs) locale ([#833](iamkun/dayjs#833)) ([f0d451f](iamkun/dayjs@f0d451f))
* Update Thai (th) locale relativeTime ([#826](iamkun/dayjs#826)) ([63b7c03](iamkun/dayjs@63b7c03)), closes [#816](iamkun/dayjs#816)
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this issue May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.23 [skip ci]
e0606a1 
## [1.8.23](iamkun/dayjs@v1.8.22...v1.8.23) (2020-03-16)

### Bug Fixes

* Add Chinese (zh) locale ([f9b8945](iamkun/dayjs@f9b8945))
* Fix IsoWeek plugin typescript definition ([#828](iamkun/dayjs#828)) ([30aab0c](iamkun/dayjs@30aab0c))
* Update Arabic (ar) locale relative time ([#836](iamkun/dayjs#836)) ([14044c6](iamkun/dayjs@14044c6))
* Update Slovak (sk) locale,  Czech (cs) locale ([#833](iamkun/dayjs#833)) ([f0d451f](iamkun/dayjs@f0d451f))
* Update Thai (th) locale relativeTime ([#826](iamkun/dayjs#826)) ([63b7c03](iamkun/dayjs@63b7c03)), closes [#816](iamkun/dayjs#816)
splashwizard pushed a commit to splashwizard/tracking-time that referenced this issue Oct 21, 2024
@semantic-release-bot
chore(release): 1.8.23 [skip ci]
c104a46 
## [1.8.23](iamkun/dayjs@v1.8.22...v1.8.23) (2020-03-16)

### Bug Fixes

* Add Chinese (zh) locale ([f9b8945](iamkun/dayjs@f9b8945))
* Fix IsoWeek plugin typescript definition ([#828](iamkun/dayjs#828)) ([30aab0c](iamkun/dayjs@30aab0c))
* Update Arabic (ar) locale relative time ([#836](iamkun/dayjs#836)) ([14044c6](iamkun/dayjs@14044c6))
* Update Slovak (sk) locale,  Czech (cs) locale ([#833](iamkun/dayjs#833)) ([f0d451f](iamkun/dayjs@f0d451f))
* Update Thai (th) locale relativeTime ([#826](iamkun/dayjs#826)) ([63b7c03](iamkun/dayjs@63b7c03)), closes [#816](iamkun/dayjs#816)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
2 participants
@ReiiYuki @iamkun