Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add month or year changes hour when utc offset is used #957

Merged
merged 2 commits into from
Jul 20, 2020

Conversation

ypresto
Copy link
Contributor

@ypresto ypresto commented Jul 11, 2020

Fixes #953

@codecov
Copy link

codecov bot commented Jul 11, 2020

Codecov Report

Merging #957 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev      #957   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          167       167           
  Lines         1423      1423           
  Branches       305       305           
=========================================
  Hits          1423      1423           
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14ab808...bf2589d. Read the comment docs.

@iamkun
Copy link
Owner

iamkun commented Jul 12, 2020

Looks sweet, thanks.

@iamkun iamkun merged commit 28ae070 into iamkun:dev Jul 20, 2020
@ypresto ypresto deleted the fix-utc-offset-add-month branch July 20, 2020 03:36
iamkun pushed a commit that referenced this pull request Jul 22, 2020
## [1.8.30](v1.8.29...v1.8.30) (2020-07-22)

### Bug Fixes

* Add Haitian Creole (ht) and Spanish Puerto Rico (es-pr) locale configs ([#958](#958)) ([b2642e2](b2642e2))
* Fix UTC plugin wrong hour bug while adding month or year  ([#957](#957)) ([28ae070](28ae070))
* Update French (fr) locale to set correct yearStart ([14ab808](14ab808)), closes [#956](#956)
@iamkun
Copy link
Owner

iamkun commented Jul 22, 2020

🎉 This PR is included in version 1.8.30 🎉

The release is available on:

Your semantic-release bot 📦🚀

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.30](iamkun/dayjs@v1.8.29...v1.8.30) (2020-07-22)

### Bug Fixes

* Add Haitian Creole (ht) and Spanish Puerto Rico (es-pr) locale configs ([#958](iamkun/dayjs#958)) ([b2642e2](iamkun/dayjs@b2642e2))
* Fix UTC plugin wrong hour bug while adding month or year  ([#957](iamkun/dayjs#957)) ([28ae070](iamkun/dayjs@28ae070))
* Update French (fr) locale to set correct yearStart ([14ab808](iamkun/dayjs@14ab808)), closes [#956](iamkun/dayjs#956)
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.30](iamkun/dayjs@v1.8.29...v1.8.30) (2020-07-22)

### Bug Fixes

* Add Haitian Creole (ht) and Spanish Puerto Rico (es-pr) locale configs ([#958](iamkun/dayjs#958)) ([b2642e2](iamkun/dayjs@b2642e2))
* Fix UTC plugin wrong hour bug while adding month or year  ([#957](iamkun/dayjs#957)) ([28ae070](iamkun/dayjs@28ae070))
* Update French (fr) locale to set correct yearStart ([14ab808](iamkun/dayjs@14ab808)), closes [#956](iamkun/dayjs#956)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add month will change hour when use utcOffset
2 participants