Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix customParseFormat plugin strict mode parse meridiem bug #1321

Merged
merged 1 commit into from
Jan 7, 2021
Merged

fix: fix customParseFormat plugin strict mode parse meridiem bug #1321

merged 1 commit into from
Jan 7, 2021

Conversation

iamkun
Copy link
Owner

@iamkun iamkun commented Jan 7, 2021 •
edited
Loading

fix #1238

@iamkun iamkun mentioned this pull request Jan 7, 2021
Closed
@codecov
Copy link

codecov bot commented Jan 7, 2021 •
edited
Loading

Codecov Report

Merging #1321 (2d90abb) into dev (344bdc0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1321   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          176       176           
  Lines         1711      1713    +2     
  Branches       392       391    -1     
=========================================
+ Hits          1711      1713    +2
Impacted Files Coverage Δ
src/plugin/customParseFormat/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 344bdc0...2d90abb. Read the comment docs.

@iamkun iamkun merged commit e49eeef into dev Jan 7, 2021
iamkun pushed a commit that referenced this pull request Jan 9, 2021
@semantic-release-bot
chore(release): 1.10.3 [skip ci]
907478e 
## [1.10.3](v1.10.2...v1.10.3) (2021-01-09)

### Bug Fixes

* fix customParseFormat plugin strict mode parse meridiem bug ([#1321](#1321)) ([e49eeef](e49eeef))
* fix weekYear plugin missing locale bug ([#1319](#1319)) ([344bdc0](344bdc0)), closes [#1304](#1304)
* update advancedFormat plugin to add format options for iso week and weekyear ([#1309](#1309)) ([2c54c64](2c54c64))
* update devHelper to add dev warning setting locale before loading ([c5cc893](c5cc893))
* update German [de] locale yearStart ([1858df8](1858df8)), closes [#1264](#1264)
@iamkun
Copy link
Owner Author

iamkun commented Jan 9, 2021

🎉 This PR is included in version 1.10.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamkun iamkun added the released label Jan 9, 2021
This was referenced Mar 16, 2021
Merged
Closed
@iamkun iamkun deleted the fix/customParseFormat-strict-mode-error branch May 26, 2021 06:57
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.10.3 [skip ci]
c779e8b 
## [1.10.3](iamkun/dayjs@v1.10.2...v1.10.3) (2021-01-09)

### Bug Fixes

* fix customParseFormat plugin strict mode parse meridiem bug ([#1321](iamkun/dayjs#1321)) ([e49eeef](iamkun/dayjs@e49eeef))
* fix weekYear plugin missing locale bug ([#1319](iamkun/dayjs#1319)) ([344bdc0](iamkun/dayjs@344bdc0)), closes [#1304](iamkun/dayjs#1304)
* update advancedFormat plugin to add format options for iso week and weekyear ([#1309](iamkun/dayjs#1309)) ([2c54c64](iamkun/dayjs@2c54c64))
* update devHelper to add dev warning setting locale before loading ([c5cc893](iamkun/dayjs@c5cc893))
* update German [de] locale yearStart ([1858df8](iamkun/dayjs@1858df8)), closes [#1264](iamkun/dayjs#1264)
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.10.3 [skip ci]
bc47fe3 
## [1.10.3](iamkun/dayjs@v1.10.2...v1.10.3) (2021-01-09)

### Bug Fixes

* fix customParseFormat plugin strict mode parse meridiem bug ([#1321](iamkun/dayjs#1321)) ([e49eeef](iamkun/dayjs@e49eeef))
* fix weekYear plugin missing locale bug ([#1319](iamkun/dayjs#1319)) ([344bdc0](iamkun/dayjs@344bdc0)), closes [#1304](iamkun/dayjs#1304)
* update advancedFormat plugin to add format options for iso week and weekyear ([#1309](iamkun/dayjs#1309)) ([2c54c64](iamkun/dayjs@2c54c64))
* update devHelper to add dev warning setting locale before loading ([c5cc893](iamkun/dayjs@c5cc893))
* update German [de] locale yearStart ([1858df8](iamkun/dayjs@1858df8)), closes [#1264](iamkun/dayjs#1264)
splashwizard pushed a commit to splashwizard/tracking-time that referenced this pull request Oct 21, 2024
@semantic-release-bot
chore(release): 1.10.3 [skip ci]
11c0a6c 
## [1.10.3](iamkun/dayjs@v1.10.2...v1.10.3) (2021-01-09)

### Bug Fixes

* fix customParseFormat plugin strict mode parse meridiem bug ([#1321](iamkun/dayjs#1321)) ([e49eeef](iamkun/dayjs@e49eeef))
* fix weekYear plugin missing locale bug ([#1319](iamkun/dayjs#1319)) ([344bdc0](iamkun/dayjs@344bdc0)), closes [#1304](iamkun/dayjs#1304)
* update advancedFormat plugin to add format options for iso week and weekyear ([#1309](iamkun/dayjs#1309)) ([2c54c64](iamkun/dayjs@2c54c64))
* update devHelper to add dev warning setting locale before loading ([c5cc893](iamkun/dayjs@c5cc893))
* update German [de] locale yearStart ([1858df8](iamkun/dayjs@1858df8)), closes [#1264](iamkun/dayjs#1264)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid dates are parsed as valid
1 participant
@iamkun