feat: add strict and custom thresholds support for relativeTime plugin

[JounQin]

close #830

[codecov]

Codecov Report

Merging #851 into dev will not change coverage by %.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev      #851   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          158       158           
  Lines         1194      1195    +1     
  Branches       243       246    +3     
=========================================
+ Hits          1194      1195    +1     

Impacted Files	Coverage Δ
src/plugin/relativeTime/index.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29a7e74...e2fde47. Read the comment docs.

[iamkun]

After carefully thinking about this PR, it seems it is enough for us to just add a thresholds option. And leave the rest to our end user.

How do you think?

[JounQin]

I think a strict preset would be helpful commonly, actually I don't understand why moment choose the loose way by default which is counterintuitive to me personally.

[iamkun]

Here's my concern, If we added strict mode, should we update all other locales relativeTime part as well? Otherwise, this might be meanless for some locale.

[iamkun]

However, if we just add a custom threshold, and leave the configuration to our user, it will be much better. All our user have to do is to use UpdateLocale to update relativeTime locale, to keep the sync with their custom thresholds.

[JounQin]

Otherwise, this might be meanless for some locale.

Yes, users have to update locales except built-in English.
But using updateLocale seems always required for other locales.
With strict option, we keep built-in locale simple.

Another idea would be supporting strict relativeTime option in locale file, but maybe it's not worth to do it.

module.exports = {
  relativeTime: {
    s: 'a few seconds',
    _s: '%d second', // strict text
    ss: '%d seconds' // fallback to `ss` if `_ss` is not present in `strict` mode
  }
}

[iamkun]

As for now, how about adding the thresholds option in this coming release only. And waiting for issues reply to decide whether to introduce strict mode or not.

[JounQin]

As for now, how about adding the thresholds option in this coming release only. And waiting for issues reply to decide whether to introduce strict mode or not.

I don't think it is feasible about "waiting for issues reply" personally.
There is only a few users care about it, maybe. 😂

[iamkun]

https://momentjs.com/docs/#/customization/relative-time-threshold/
https://momentjs.com/docs/#/customization/relative-time-rounding/

moment has these two options. We can do this too to suit your needs.

{
threshold: {},
rounding: Math.floor
}

[JounQin]

@iamkun Updated according to your last comment.

[iamkun]

That's great! Thanks.

[iamkun]

THX

[iamkun]

🎉 This PR is included in version 1.8.24 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀