Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split model.jl and visibilities.jl into smaller files #30

Open
iancze opened this issue Jun 18, 2020 · 0 comments
Open

Split model.jl and visibilities.jl into smaller files #30

iancze opened this issue Jun 18, 2020 · 0 comments
Assignees

Comments

@iancze
Copy link
Owner

iancze commented Jun 18, 2020

These src/ files are quite long:model.jl is > 1000 lines and visibilities.jl is 900 lines. While it is true that the code within each file broadly supports either of these objectives, it can clearly be broken down into smaller, more carefully named modules. The existing length makes maintaining and extending these components rather cumbersome.

@iancze iancze self-assigned this Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant