From 7421d1d6897d0dfca0608cdf91401979f332bb24 Mon Sep 17 00:00:00 2001 From: cspeisman Date: Sun, 15 Jan 2023 08:51:04 -0500 Subject: [PATCH] bugfix: moves EDITOR_TO_ON_CHANGE into useEffect for double useEffect call in react 18 --- packages/slate-react/src/components/slate.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/slate-react/src/components/slate.tsx b/packages/slate-react/src/components/slate.tsx index 0dedd53592..0a03ed82b2 100644 --- a/packages/slate-react/src/components/slate.tsx +++ b/packages/slate-react/src/components/slate.tsx @@ -61,9 +61,9 @@ export const Slate = (props: { handleSelectorChange(editor) }, [onChange]) - EDITOR_TO_ON_CHANGE.set(editor, onContextChange) - useEffect(() => { + EDITOR_TO_ON_CHANGE.set(editor, onContextChange) + return () => { EDITOR_TO_ON_CHANGE.set(editor, () => {}) unmountRef.current = true