Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression related to focus since 0.99.0 (Cannot resolve DOM point...) #5561

Closed
philicious opened this issue Nov 19, 2023 · 1 comment
Closed

Regression related to focus since 0.99.0 (Cannot resolve DOM point...) #5561

philicious opened this issue Nov 19, 2023 · 1 comment
Labels
bug

Comments

@philicious
Copy link

Description
0.99.0 must have introduced a regression as formerly working ReactEditor.focus(editor) now crashes with "Cannot resolve DOM point..." in some cases.
So I guess it was this PR #5516 as its calling toDOMRange

Its happening if we call it right after editor.undo() and the operations being:
undo split:
insert_node
remove_node
remove_node
set_select
CRASH

undo merge:
insert_node
remove_node
insert_node
CRASH

if we call editor.deselect() before editor.focus() it doesnt crash as the new code from 0.99.0 isnt triggered then
@philicious philicious added the bug label Nov 19, 2023
@philicious
Copy link
Author

this is solved by #5527 in 0.101.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@philicious