Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composition / Invalid Schema Errors are incorrectly shown as passes #32

Open
comp615 opened this issue Apr 21, 2023 · 0 comments · May be fixed by #33
Open

Composition / Invalid Schema Errors are incorrectly shown as passes #32

comp615 opened this issue Apr 21, 2023 · 0 comments · May be fixed by #33

Comments

@comp615
Copy link
Contributor

comp615 commented Apr 21, 2023

Describe the bug
If you upload a schema which is not valid (i.e. does not compile), then the check in Apollo Studio will fail, but the GHA will pass with no indication. I encountered this in particular from federation version upgrade errors on Apollo.

This only occurs if alwaysComment is not set.

To Reproduce
Steps to reproduce the behavior:

  1. Change your schema by setting a scalar to a non-sensical name for instance
  2. Run the action against the new schema
  3. Observe the check passes.
  4. But look in Apollo studio and notice the check fails with build errors

Expected behavior
The GHA should fail any time the Apollo Studio check fails. Otherwise it's possible for silent breakages.

Additional context
I will provide a PR for this shortly!

@comp615 comp615 linked a pull request Apr 21, 2023 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant