Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --audio-only flag #1304

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Add --audio-only flag #1304

merged 3 commits into from
Jan 5, 2024

Conversation

GNUSheep
Copy link
Contributor

@GNUSheep GNUSheep commented Jan 2, 2024

I think this option is more user friendly than choosing audio stream from streams output.

I tested it out with youtube videos, and it's working pretty fine.

downloader/downloader.go Outdated Show resolved Hide resolved
downloader/downloader.go Show resolved Hide resolved
@GNUSheep
Copy link
Contributor Author

GNUSheep commented Jan 3, 2024

Thanks for the review, I resolved all proposed changes.

downloader/downloader.go Outdated Show resolved Hide resolved
@GNUSheep
Copy link
Contributor Author

GNUSheep commented Jan 4, 2024

Thanks again for review. I fixed errors, now everything should be all right

Copy link
Owner

@iawia002 iawia002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@iawia002 iawia002 merged commit bd142b2 into iawia002:master Jan 5, 2024
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants