Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to feed source label may be lost when closing browser tab/navigating away #922

Open
binh-dam-ibigroup opened this issue Mar 7, 2023 · 0 comments

Comments

@binh-dam-ibigroup
Copy link
Contributor

Observed behavior (please include a screenshot if possible)

In some browsers (Firefox?), when the user closes the tab/window or navigates away from datatools, componentWillUnmount will not necessarily be triggered, and changes to feed source labels in the "General Settings" tab may be lost. The correct DOM event to handle is sendBeacon, which is currently not compatible with datatools server (only unauthenticated POST requests are allowed when sendBeacon is triggered).

Expected behavior

Changes to labels should be persisted.

Steps to reproduce the problem

  1. Set up labels in a project.
  2. Open a feed source and go to the "General Settings" tab.
  3. Tick one or more labels
  4. Close the browser tab
  5. Reopen the feed source general settings in another tab
  6. Notice the changes to labels were not persisted.

Any special notes on configuration used

n/a

Version of datatools-ui and datatools-server if applicable (exact commit hash or branch name)

Current versions of datatools (both UI and server)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant