This repository has been archived by the owner on Mar 29, 2023. It is now read-only.
fix: use TIMESTAMP_SUB for TimstampSub operation #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorrect SQL expression was specified for TimestampSub.
tswast
reviewed
Apr 26, 2021
| @@ -419,7 +419,7 @@ def _formatter(translator, expr): | |||
| 'TIMESTAMP_ADD', {'h', 'm', 's', 'ms', 'us'} | |||
| ), | |||
| ops.TimestampSub: _timestamp_op( | |||
| 'TIMESTAMP_DIFF', {'h', 'm', 's', 'ms', 'us'} | |||
| 'TIMESTAMP_SUB', {'h', 'm', 's', 'ms', 'us'} | |||
There was a problem hiding this comment.
I can confirm that this is the correct function for TimestampSub
It appears there is a TimestampDiff operator as well, so we might as well add support for that while we're here.
There was a problem hiding this comment.
Or actually, I can do that in a follow-up PR
tswast
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorrect SQL expression was specified for TimestampSub.