Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No module named 'numpy' on default install #151

Closed
lostmygithubaccount opened this issue Sep 5, 2024 · 1 comment · Fixed by #152
Closed

No module named 'numpy' on default install #151

lostmygithubaccount opened this issue Sep 5, 2024 · 1 comment · Fixed by #152
Assignees

Comments

@lostmygithubaccount
Copy link
Member

to reproduce install gh/uv:

gh repo clone ibis-project/ibis-ml
cd ibis-ml
uv venv
. .venv/bin/activate
uv pip install -e .

then try importing IbisML:

import ibis_ml as ml

traceback:

[ins] In [1]: import ibis_ml as ml
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
Cell In[1], line 1
----> 1 import ibis_ml as ml

File ~/repos/ibis-ml/ibis_ml/__init__.py:7
      3 __version__ = "0.1.2"
      5 import pprint
----> 7 from ibis_ml.core import Recipe, Step
      8 from ibis_ml.select import (
      9     categorical,
     10     cols,
   (...)
     27     where,
     28 )
     29 from ibis_ml.steps import *

File ~/repos/ibis-ml/ibis_ml/core.py:15
     13 import ibis.expr.operations as ops
     14 import ibis.expr.types as ir
---> 15 import numpy as np
     16 import pandas as pd
     17 import pyarrow as pa

ModuleNotFoundError: No module named 'numpy'

numpy and pandas were removed as required dependencies for the default installation of Ibis: ibis-project/ibis#9564

@deepyaman
Copy link
Collaborator

Thanks for raising. The NumPy and pandas dependencies should only be required when working with these data types (e.g. they shouldn't be needed when working with Polars dataframes), so it's mostly a question of importing in the scope of these functions. @jitingxu1 I see you had already looked at this issue; can you see if can update your PR (or raise a new PR) to do this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants