-
Notifications
You must be signed in to change notification settings - Fork 590
/
conftest.py
794 lines (649 loc) · 22.7 KB
/
conftest.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
from __future__ import annotations
import contextlib
import importlib
import importlib.metadata
import itertools
from functools import cache
from pathlib import Path
from typing import TYPE_CHECKING, Any
import _pytest
import numpy as np
import pandas as pd
import pytest
import sqlalchemy as sa
from packaging.requirements import Requirement
from packaging.version import parse as vparse
import ibis
import ibis.common.exceptions as com
from ibis import util
from ibis.backends.base import CanCreateDatabase, CanCreateSchema, _get_backend_names
from ibis.conftest import WINDOWS
if TYPE_CHECKING:
from collections.abc import Iterable
TEST_TABLES = {
"functional_alltypes": ibis.schema(
{
"id": "int32",
"bool_col": "boolean",
"tinyint_col": "int8",
"smallint_col": "int16",
"int_col": "int32",
"bigint_col": "int64",
"float_col": "float32",
"double_col": "float64",
"date_string_col": "string",
"string_col": "string",
"timestamp_col": "timestamp",
"year": "int32",
"month": "int32",
}
),
"diamonds": ibis.schema(
{
"carat": "float64",
"cut": "string",
"color": "string",
"clarity": "string",
"depth": "float64",
"table": "float64",
"price": "int64",
"x": "float64",
"y": "float64",
"z": "float64",
}
),
"batting": ibis.schema(
{
"playerID": "string",
"yearID": "int64",
"stint": "int64",
"teamID": "string",
"lgID": "string",
"G": "int64",
"AB": "int64",
"R": "int64",
"H": "int64",
"X2B": "int64",
"X3B": "int64",
"HR": "int64",
"RBI": "int64",
"SB": "int64",
"CS": "int64",
"BB": "int64",
"SO": "int64",
"IBB": "int64",
"HBP": "int64",
"SH": "int64",
"SF": "int64",
"GIDP": "int64",
}
),
"awards_players": ibis.schema(
{
"playerID": "string",
"awardID": "string",
"yearID": "int64",
"lgID": "string",
"tie": "string",
"notes": "string",
}
),
"astronauts": ibis.schema(
{
"id": "int64",
"number": "int64",
"nationwide_number": "int64",
"name": "string",
"original_name": "string",
"sex": "string",
"year_of_birth": "int64",
"nationality": "string",
"military_civilian": "string",
"selection": "string",
"year_of_selection": "int64",
"mission_number": "int64",
"total_number_of_missions": "int64",
"occupation": "string",
"year_of_mission": "int64",
"mission_title": "string",
"ascend_shuttle": "string",
"in_orbit": "string",
"descend_shuttle": "string",
"hours_mission": "float64",
"total_hrs_sum": "float64",
"field21": "int64",
"eva_hrs_mission": "float64",
"total_eva_hrs": "float64",
}
),
}
# We want to check for exceptions in xfail tests for two reasons:
# * xfail tests without exception checking may hide problems.
# For example, the implementation may work, but we may have an error in the test that needs to be fixed.
# * facilitates code reviews
# For now, many of our tests don't do this, and we're working to change this situation
# by improving all tests file by file. All files that have already been improved are
# added to this list to prevent regression.
FIlES_WITH_STRICT_EXCEPTION_CHECK = [
"ibis/backends/tests/test_api.py",
"ibis/backends/tests/test_array.py",
"ibis/backends/tests/test_aggregation.py",
"ibis/backends/tests/test_binary.py",
"ibis/backends/tests/test_numeric.py",
"ibis/backends/tests/test_column.py",
"ibis/backends/tests/test_string.py",
"ibis/backends/tests/test_temporal.py",
"ibis/backends/tests/test_uuid.py",
"ibis/backends/tests/test_window.py",
]
ALL_BACKENDS = set(_get_backend_names())
@pytest.fixture(scope="session")
def data_dir() -> Path:
"""Return the test data directory.
Returns
-------
Path
Test data directory
"""
root = Path(__file__).absolute().parents[2]
return root / "ci" / "ibis-testing-data"
def recreate_database(
url: sa.engine.url.URL,
database: str,
**kwargs: Any,
) -> None:
"""Drop the `database` at `url`, if it exists.
Create a new, blank database with the same name.
Parameters
----------
url : url.sa.engine.url.URL
Connection url to the database
database : str
Name of the database to be dropped.
"""
engine = sa.create_engine(url.set(database=""), **kwargs)
if url.database is not None:
with engine.begin() as con:
con.exec_driver_sql(f"DROP DATABASE IF EXISTS {database}")
con.exec_driver_sql(f"CREATE DATABASE {database}")
def init_database(
url: sa.engine.url.URL,
database: str,
schema: Iterable[str] | None = None,
recreate: bool = True,
isolation_level: str | None = "AUTOCOMMIT",
**kwargs: Any,
) -> sa.engine.Engine:
"""Initialise `database` at `url` with `schema`.
If `recreate`, drop the `database` at `url`, if it exists.
Parameters
----------
url : url.sa.engine.url.URL
Connection url to the database
database : str
Name of the database to be dropped
schema : TextIO
File object containing schema to use
recreate : bool
If true, drop the database if it exists
isolation_level : str
Transaction isolation_level
Returns
-------
sa.engine.Engine
SQLAlchemy engine object
"""
if isolation_level is not None:
kwargs["isolation_level"] = isolation_level
if recreate:
recreate_database(url, database, **kwargs)
try:
url.database = database
except AttributeError:
url = url.set(database=database)
engine = sa.create_engine(url, **kwargs)
if schema:
with engine.begin() as conn:
util.consume(map(conn.exec_driver_sql, schema))
return engine
def _get_backend_conf(backend_str: str):
"""Convert a backend string to the test class for the backend."""
conftest = importlib.import_module(f"ibis.backends.{backend_str}.tests.conftest")
return conftest.TestConf
def _get_backend_from_parts(parts: tuple[str, ...]) -> str | None:
"""Return the backend part of a test file's path parts.
Examples
--------
>>> _get_backend_from_parts(("/", "ibis", "backends", "sqlite", "tests"))
"sqlite"
"""
try:
index = parts.index("backends")
except ValueError:
return None
else:
return parts[index + 1]
def pytest_ignore_collect(path, config):
# get the backend path part
#
# path is a py.path.local object hence the conversion to Path first
backend = _get_backend_from_parts(Path(path).parts)
if backend is None or backend not in _get_backend_names():
return False
# we evaluate the marker early so that we don't trigger
# an import of conftest files for the backend, which will
# import the backend and thus require dependencies that may not
# exist
#
# alternatives include littering library code with pytest.importorskips
# and moving all imports close to their use site
#
# the latter isn't tenable for backends that use multiple dispatch
# since the rules are executed at import time
mark_expr = config.getoption("-m")
# we can't let the empty string pass through, since `'' in s` is `True` for
# any `s`; if no marker was passed don't ignore the collection of `path`
if not mark_expr:
return False
expr = _pytest.mark.expression.Expression.compile(mark_expr)
# we check the "backend" marker as well since if that's passed
# any file matching a backed should be skipped
keep = expr.evaluate(lambda s: s in (backend, "backend"))
return not keep
def pytest_collection_modifyitems(session, config, items):
all_backends = _get_backend_names()
additional_markers = []
try:
import pyspark
except ImportError:
pyspark = None
unrecognized_backends = set()
for item in items:
# Yell loudly if unrecognized backend in notimpl, notyet or never
for name in ("notimpl", "notyet", "never"):
for mark in item.iter_markers(name=name):
if backend := set(util.promote_list(mark.args[0])).difference(
ALL_BACKENDS
):
unrecognized_backends.add(
f"""Unrecognize backend(s) {backend} passed to {name} marker in
{item.path}::{item.originalname}"""
)
# add the backend marker to any tests are inside "ibis/backends"
parts = item.path.parts
backend = _get_backend_from_parts(parts)
if backend is not None and backend in all_backends:
item.add_marker(getattr(pytest.mark, backend))
item.add_marker(pytest.mark.backend)
elif "backends" not in parts and not tuple(
itertools.chain(
*(item.iter_markers(name=name) for name in all_backends),
item.iter_markers(name="backend"),
)
):
# anything else is a "core" test and is run by default
if not any(item.iter_markers(name="benchmark")):
item.add_marker(pytest.mark.core)
# skip or xfail pyspark tests that run afoul of our non-ancient stack
for _ in item.iter_markers(name="pyspark"):
if not isinstance(item, pytest.DoctestItem):
additional_markers.append(
(
item,
[
pytest.mark.xfail(
vparse(pd.__version__) >= vparse("2"),
reason="PySpark doesn't support pandas>=2",
),
pytest.mark.skipif(
pyspark is not None
and vparse(pyspark.__version__) < vparse("3.3.3")
and vparse(np.__version__) >= vparse("1.24"),
reason="PySpark doesn't support numpy >= 1.24",
),
],
)
)
if unrecognized_backends:
raise pytest.PytestCollectionWarning("\n" + "\n".join(unrecognized_backends))
for item, markers in additional_markers:
for marker in markers:
item.add_marker(marker)
@cache
def _get_backends_to_test(
keep: tuple[str, ...] = (),
discard: tuple[str, ...] = (),
) -> list[Any]:
"""Get a list of `TestConf` classes of the backends to test."""
backends = _get_backend_names()
if discard:
backends = backends.difference(discard)
if keep:
backends = backends.intersection(keep)
return [
pytest.param(
backend,
marks=[getattr(pytest.mark, backend), pytest.mark.backend],
id=backend,
)
for backend in sorted(backends)
]
def pytest_runtest_call(item):
"""Dynamically add various custom markers."""
backend = [
getattr(backend, "name", lambda backend=backend: backend)()
for key, backend in item.funcargs.items()
if key.endswith(("backend", "backend_name"))
]
if len(backend) > 1:
raise ValueError(
f"test {item.originalname} was supplied with multiple backend "
f"objects simultaneously. This is likely due to a leaky fixture."
f"Backends passed: {(back.name() for back in backend)}"
)
if not backend:
# Check item path to see if test is in backend-specific folder
backend = set(_get_backend_names()).intersection(item.path.parts)
if not backend:
return
backend = next(iter(backend))
if tpch_markers := list(item.iter_markers(name="tpch")):
assert len(tpch_markers) == 1
# TODO: there has to be a better way than hacking `_fixtureinfo`
item._fixtureinfo.argnames += ("backend", "snapshot")
# Ibis hasn't exposed existing functionality
# This xfails so that you know when it starts to pass
for marker in item.iter_markers(name="notimpl"):
if backend in marker.args[0]:
if (
item.location[0] in FIlES_WITH_STRICT_EXCEPTION_CHECK
and "raises" not in marker.kwargs.keys()
):
raise ValueError("notimpl requires a raises")
kwargs = marker.kwargs.copy()
kwargs.setdefault("reason", f"Feature not yet exposed in {backend}")
item.add_marker(pytest.mark.xfail(**kwargs))
# Functionality is unavailable upstream (but could be)
# This xfails so that you know when it starts to pass
for marker in item.iter_markers(name="notyet"):
if backend in marker.args[0]:
if (
item.location[0] in FIlES_WITH_STRICT_EXCEPTION_CHECK
and "raises" not in marker.kwargs.keys()
):
raise ValueError("notyet requires a raises")
kwargs = marker.kwargs.copy()
kwargs.setdefault("reason", f"Feature not available upstream for {backend}")
item.add_marker(pytest.mark.xfail(**kwargs))
for marker in item.iter_markers(name="never"):
if backend in marker.args[0]:
if "reason" not in marker.kwargs.keys():
raise ValueError("never requires a reason")
item.add_marker(pytest.mark.xfail(**marker.kwargs))
# Something has been exposed as broken by a new test and it shouldn't be
# imperative for a contributor to fix it just because they happened to
# bring it to attention -- USE SPARINGLY
for marker in item.iter_markers(name="broken"):
if backend in marker.args[0]:
if (
item.location[0] in FIlES_WITH_STRICT_EXCEPTION_CHECK
and "raises" not in marker.kwargs.keys()
):
raise ValueError("broken requires a raises")
kwargs = marker.kwargs.copy()
kwargs.setdefault("reason", f"Feature is failing on {backend}")
item.add_marker(pytest.mark.xfail(**kwargs))
for marker in item.iter_markers(name="xfail_version"):
kwargs = marker.kwargs.copy()
if backend not in kwargs:
continue
provided_reason = kwargs.pop("reason", None)
specs = kwargs.pop(backend)
failing_specs = []
for spec in specs:
req = Requirement(spec)
if req.specifier.contains(importlib.import_module(req.name).__version__):
failing_specs.append(spec)
reason = f"{backend} backend test fails with {backend}{specs}"
if provided_reason is not None:
reason += f"; {provided_reason}"
if failing_specs:
item.add_marker(pytest.mark.xfail(reason=reason, **kwargs))
@pytest.fixture(params=_get_backends_to_test(), scope="session")
def backend(request, data_dir, tmp_path_factory, worker_id):
"""Return an instance of BackendTest, loaded with data."""
cls = _get_backend_conf(request.param)
return cls.load_data(data_dir, tmp_path_factory, worker_id)
@pytest.fixture(scope="session")
def con(backend):
"""Instance of a backend client."""
return backend.connection
@pytest.fixture(scope="session")
def con_create_database(con):
if isinstance(con, CanCreateDatabase):
return con
else:
pytest.skip(f"{con.name} backend cannot create databases")
@pytest.fixture(scope="session")
def con_create_schema(con):
if isinstance(con, CanCreateSchema):
return con
else:
pytest.skip(f"{con.name} backend cannot create schemas")
@pytest.fixture(scope="session")
def con_create_database_schema(con):
if isinstance(con, CanCreateDatabase) and isinstance(con, CanCreateSchema):
return con
else:
pytest.skip(f"{con.name} backend cannot create both database and schemas")
def _setup_backend(request, data_dir, tmp_path_factory, worker_id):
if (backend := request.param) == "duckdb" and WINDOWS:
pytest.xfail(
"windows prevents two connections to the same duckdb file "
"even in the same process"
)
else:
cls = _get_backend_conf(backend)
return cls.load_data(data_dir, tmp_path_factory, worker_id)
@pytest.fixture(
params=_get_backends_to_test(discard=("dask", "pandas")),
scope="session",
)
def ddl_backend(request, data_dir, tmp_path_factory, worker_id):
"""Set up the backends that are SQL-based."""
return _setup_backend(request, data_dir, tmp_path_factory, worker_id)
@pytest.fixture(scope="session")
def ddl_con(ddl_backend):
"""Instance of Client, already connected to the db (if applies)."""
return ddl_backend.connection
@pytest.fixture(
params=_get_backends_to_test(
keep=(
"duckdb",
"exasol",
"mssql",
"mysql",
"oracle",
"postgres",
"snowflake",
"sqlite",
"trino",
)
),
scope="session",
)
def alchemy_backend(request, data_dir, tmp_path_factory, worker_id):
"""Set up the SQLAlchemy-based backends."""
return _setup_backend(request, data_dir, tmp_path_factory, worker_id)
@pytest.fixture(scope="session")
def alchemy_con(alchemy_backend):
"""Instance of Client, already connected to the db (if applies)."""
return alchemy_backend.connection
@pytest.fixture(
params=_get_backends_to_test(keep=("dask", "pandas", "pyspark")),
scope="session",
)
def udf_backend(request, data_dir, tmp_path_factory, worker_id):
"""Runs the UDF-supporting backends."""
cls = _get_backend_conf(request.param)
return cls.load_data(data_dir, tmp_path_factory, worker_id)
@pytest.fixture(scope="session")
def udf_con(udf_backend):
"""Instance of Client, already connected to the db (if applies)."""
return udf_backend.connection
@pytest.fixture(scope="session")
def alltypes(backend):
return backend.functional_alltypes
@pytest.fixture(scope="session")
def json_t(backend):
return backend.json_t
@pytest.fixture(scope="session")
def struct(backend):
return backend.struct
@pytest.fixture(scope="session")
def sorted_alltypes(alltypes):
return alltypes.order_by("id")
@pytest.fixture(scope="session")
def udf_alltypes(udf_backend):
return udf_backend.functional_alltypes
@pytest.fixture(scope="session")
def batting(backend):
return backend.batting
@pytest.fixture(scope="session")
def awards_players(backend):
return backend.awards_players
@pytest.fixture
def analytic_alltypes(alltypes):
return alltypes
@pytest.fixture(scope="session")
def df(alltypes):
return alltypes.execute()
@pytest.fixture(scope="session")
def struct_df(struct):
return struct.execute()
@pytest.fixture(scope="session")
def udf_df(udf_alltypes):
return udf_alltypes.execute()
@pytest.fixture(scope="session")
def sorted_df(df):
return df.sort_values("id").reset_index(drop=True)
@pytest.fixture(scope="session")
def batting_df(batting):
return batting.execute(limit=None)
@pytest.fixture(scope="session")
def awards_players_df(awards_players):
return awards_players.execute(limit=None)
@pytest.fixture(scope="session")
def geo_df(geo):
if geo is not None:
return geo.execute(limit=None)
return None
@pytest.fixture
def alchemy_temp_table(alchemy_con) -> str:
"""Return a temporary table name.
Parameters
----------
alchemy_con : ibis.backends.base.Client
Yields
------
name : string
Random table name for a temporary usage.
"""
name = util.gen_name("alchemy_table")
yield name
with contextlib.suppress(NotImplementedError):
alchemy_con.drop_table(name, force=True)
@pytest.fixture
def temp_table(con) -> str:
"""Return a temporary table name.
Parameters
----------
con : ibis.backends.base.Client
Yields
------
name : string
Random table name for a temporary usage.
"""
name = util.gen_name("temp_table")
yield name
with contextlib.suppress(NotImplementedError):
con.drop_table(name, force=True)
@pytest.fixture
def temp_table2(con) -> str:
name = util.gen_name("temp_table2")
yield name
with contextlib.suppress(NotImplementedError):
con.drop_table(name, force=True)
@pytest.fixture
def temp_table_orig(con, temp_table):
name = f"{temp_table}_orig"
yield name
with contextlib.suppress(NotImplementedError):
con.drop_table(name, force=True)
@pytest.fixture
def temp_view(ddl_con) -> str:
"""Return a temporary view name.
Parameters
----------
ddl_con : backend connection
Yields
------
name : string
Random view name for a temporary usage.
"""
name = util.gen_name("view")
yield name
with contextlib.suppress(NotImplementedError):
ddl_con.drop_view(name, force=True)
@pytest.fixture
def alternate_current_database(ddl_con, ddl_backend) -> str:
"""Create a temporary database and yield its name. Drops the created
database upon completion.
Parameters
----------
ddl_con : ibis.backends.base.Client
Yields
------
str
"""
name = util.gen_name("database")
try:
ddl_con.create_database(name)
except AttributeError:
pytest.skip(f"{ddl_backend.name()} doesn't have a `create_database` method.")
yield name
with contextlib.suppress(com.UnsupportedOperationError):
ddl_con.drop_database(name, force=True)
@pytest.fixture
def test_employee_schema() -> ibis.schema:
sch = ibis.schema(
[
("first_name", "string"),
("last_name", "string"),
("department_name", "string"),
("salary", "float64"),
]
)
return sch
@pytest.fixture
def test_employee_data_1():
df = pd.DataFrame(
{
"first_name": ["A", "B", "C"],
"last_name": ["D", "E", "F"],
"department_name": ["AA", "BB", "CC"],
"salary": [100.0, 200.0, 300.0],
}
)
return df
@pytest.fixture
def test_employee_data_2():
df2 = pd.DataFrame(
{
"first_name": ["X", "Y", "Z"],
"last_name": ["A", "B", "C"],
"department_name": ["XX", "YY", "ZZ"],
"salary": [400.0, 500.0, 600.0],
}
)
return df2