From 04d3a897fb7269bfaa83e3a804655d2b7a9d2768 Mon Sep 17 00:00:00 2001 From: Phillip Cloud <417981+cpcloud@users.noreply.github.com> Date: Sun, 21 May 2023 06:36:49 -0400 Subject: [PATCH] fix(trino): fix incorrect `version` computation --- ibis/backends/trino/__init__.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/ibis/backends/trino/__init__.py b/ibis/backends/trino/__init__.py index 1efedcdc9843..6e6244859b81 100644 --- a/ibis/backends/trino/__init__.py +++ b/ibis/backends/trino/__init__.py @@ -3,6 +3,7 @@ from __future__ import annotations import warnings +from functools import cached_property from typing import Iterator import sqlalchemy as sa @@ -26,12 +27,10 @@ class Backend(BaseAlchemyBackend): def current_database(self) -> str: raise NotImplementedError(type(self)) - @property + @cached_property def version(self) -> str: - # TODO: there is a `PRAGMA version` we could use instead - import importlib.metadata - - return importlib.metadata.version("trino") + with self.begin() as con: + return con.execute(sa.select(sa.func.version())).scalar() def do_connect( self,