From 887f572a4228d9bb7de16cfd3b367a5cb90cd62d Mon Sep 17 00:00:00 2001
From: Daniel Mesejo <mesejoleon@gmail.com>
Date: Tue, 25 Apr 2023 11:18:25 +0200
Subject: [PATCH] feat(postgres): add ApproxMedian aggregation

---
 ibis/backends/postgres/registry.py             | 9 +++++++++
 ibis/backends/postgres/tests/test_functions.py | 2 +-
 ibis/backends/tests/test_aggregation.py        | 2 +-
 3 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/ibis/backends/postgres/registry.py b/ibis/backends/postgres/registry.py
index a3c573b198b3..0dcfb3a3acc5 100644
--- a/ibis/backends/postgres/registry.py
+++ b/ibis/backends/postgres/registry.py
@@ -444,6 +444,14 @@ def _quantile(t, op):
     )
 
 
+def _approx_median(t, op):
+    arg = op.arg
+    if (where := op.where) is not None:
+        arg = ops.Where(where, arg, None)
+
+    return sa.func.percentile_cont(0.5).within_group(t.translate(arg))
+
+
 def _binary_variance_reduction(func):
     def variance_compiler(t, op):
         x = op.left
@@ -659,6 +667,7 @@ def _unnest(t, op):
         ops.Correlation: _corr,
         ops.BitwiseXor: _bitwise_op("#"),
         ops.Mode: _mode,
+        ops.ApproxMedian: _approx_median,
         ops.Quantile: _quantile,
         ops.MultiQuantile: _quantile,
         ops.TimestampNow: lambda t, op: sa.literal_column(
diff --git a/ibis/backends/postgres/tests/test_functions.py b/ibis/backends/postgres/tests/test_functions.py
index 0ca064d5b1cb..2a63b64d25c3 100644
--- a/ibis/backends/postgres/tests/test_functions.py
+++ b/ibis/backends/postgres/tests/test_functions.py
@@ -717,7 +717,7 @@ def test_interactive_repr_shows_error(alltypes):
     # #591. Doing this in PostgreSQL because so many built-in functions are
     # not available
 
-    expr = alltypes.double_col.approx_median()
+    expr = alltypes.int_col.convert_base(10, 2)
 
     with config.option_context('interactive', True):
         result = repr(expr)
diff --git a/ibis/backends/tests/test_aggregation.py b/ibis/backends/tests/test_aggregation.py
index e53464bdd2dc..e3d3716dc673 100644
--- a/ibis/backends/tests/test_aggregation.py
+++ b/ibis/backends/tests/test_aggregation.py
@@ -1010,7 +1010,7 @@ def test_corr_cov(
 
 
 @pytest.mark.notimpl(
-    ["datafusion", "mysql", "postgres", "sqlite", "snowflake", "mssql", "druid"],
+    ["datafusion", "mysql", "sqlite", "snowflake", "mssql", "druid"],
     raises=com.OperationNotDefinedError,
 )
 @pytest.mark.broken(