From a507d17e45dafbe8b50eee71e8b87de0cfcd3931 Mon Sep 17 00:00:00 2001 From: Krzysztof Date: Sun, 5 Feb 2023 07:54:19 +0100 Subject: [PATCH] feat(clickhouse): implement ops.StringAscii --- ibis/backends/clickhouse/compiler/values.py | 1 + ibis/backends/tests/test_string.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/ibis/backends/clickhouse/compiler/values.py b/ibis/backends/clickhouse/compiler/values.py index c358c6237d1d..f1e9cc027c76 100644 --- a/ibis/backends/clickhouse/compiler/values.py +++ b/ibis/backends/clickhouse/compiler/values.py @@ -1029,6 +1029,7 @@ def formatter(op, **kw): ops.Strip: "trimBoth", ops.RegexSearch: "match", ops.RegexReplace: "replaceRegexpAll", + ops.StringAscii: "ascii", # Temporal operations ops.Date: "toDate", ops.TimestampNow: "now", diff --git a/ibis/backends/tests/test_string.py b/ibis/backends/tests/test_string.py index c416bb3f74fc..b22a640a608b 100644 --- a/ibis/backends/tests/test_string.py +++ b/ibis/backends/tests/test_string.py @@ -208,7 +208,7 @@ def test_string_col_is_unicode(alltypes, df): lambda t: t.string_col.ascii_str(), lambda t: t.string_col.map(ord).astype('int32'), id='ascii_str', - marks=pytest.mark.notimpl(["clickhouse", "datafusion", "polars"]), + marks=pytest.mark.notimpl(["datafusion", "polars"]), ), param( lambda t: t.string_col.length(),