From b1d76728b1c44ad3092c8f3edaa8c83e145f3216 Mon Sep 17 00:00:00 2001 From: Krzysztof Date: Thu, 16 Feb 2023 02:55:45 +0100 Subject: [PATCH] feat(datafusion): implement ops.StringAscii --- ibis/backends/datafusion/compiler.py | 5 +++++ ibis/backends/tests/test_string.py | 4 +--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/ibis/backends/datafusion/compiler.py b/ibis/backends/datafusion/compiler.py index bdc5f12573e1..b6054a7930e6 100644 --- a/ibis/backends/datafusion/compiler.py +++ b/ibis/backends/datafusion/compiler.py @@ -476,6 +476,11 @@ def string_translate(op): return df.functions.translate(*map(translate, op.args)) +@translate.register(ops.StringAscii) +def string_ascii(op): + return df.functions.ascii(translate(op.arg)) + + @translate.register(ops.RegexExtract) def regex_extract(op): arg = translate(op.arg) diff --git a/ibis/backends/tests/test_string.py b/ibis/backends/tests/test_string.py index 901d305e6b59..4292054e719f 100644 --- a/ibis/backends/tests/test_string.py +++ b/ibis/backends/tests/test_string.py @@ -361,9 +361,7 @@ def test_string_col_is_unicode(alltypes, df): lambda t: t.string_col.ascii_str(), lambda t: t.string_col.map(ord).astype('int32'), id='ascii_str', - marks=pytest.mark.notimpl( - ["datafusion", "polars"], raises=com.OperationNotDefinedError - ), + marks=pytest.mark.notimpl(["polars"], raises=com.OperationNotDefinedError), ), param( lambda t: t.string_col.length(),