From bc28968387a2f53871665f59caa910acd931ab49 Mon Sep 17 00:00:00 2001 From: Phillip Cloud <417981+cpcloud@users.noreply.github.com> Date: Tue, 23 Jul 2024 15:54:35 -0400 Subject: [PATCH] test: remove bogus test case --- ibis/tests/expr/test_case.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/ibis/tests/expr/test_case.py b/ibis/tests/expr/test_case.py index da8a25582c64b..dbd0b9d21746f 100644 --- a/ibis/tests/expr/test_case.py +++ b/ibis/tests/expr/test_case.py @@ -215,15 +215,11 @@ def test_case_mixed_type(): assert result["label"].type().equals(dt.string) -def test_err_on_nonbool(table): +def test_err_on_nonbool_expr(table): with pytest.raises(SignatureValidationError): ibis.case().when(table.a, "bar").else_("baz").end() - - -@pytest.mark.xfail(reason="Literal('foo', type=bool), should error, but doesn't") -def test_err_on_nonbool2(): with pytest.raises(SignatureValidationError): - ibis.case().when("foo", "bar").else_("baz").end() + ibis.case().when(ibis.literal(1), "bar").else_("baz").end() def test_err_on_noncomparable(table):