From c425f6861ed0ee19444aced4687a8b8b4a7901c4 Mon Sep 17 00:00:00 2001
From: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
Date: Wed, 18 Jan 2023 15:35:28 -0500
Subject: [PATCH] feat(snowflake): implement `ArrayCollect`

---
 ibis/backends/snowflake/registry.py     |  2 +-
 ibis/backends/tests/test_aggregation.py | 10 +---------
 2 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/ibis/backends/snowflake/registry.py b/ibis/backends/snowflake/registry.py
index ead891a22c22..60290392ab56 100644
--- a/ibis/backends/snowflake/registry.py
+++ b/ibis/backends/snowflake/registry.py
@@ -214,6 +214,7 @@ def _map(_, op):
             *map(t.translate, op.cols)
         ),
         ops.ArraySlice: _array_slice,
+        ops.ArrayCollect: reduction(sa.func.array_agg),
         ops.Map: _map,
     }
 )
@@ -231,7 +232,6 @@ def _map(_, op):
     # ibis.expr.operations.reductions
     ops.All,
     ops.Any,
-    ops.ArrayCollect,
     ops.BitAnd,
     ops.BitOr,
     ops.BitXor,
diff --git a/ibis/backends/tests/test_aggregation.py b/ibis/backends/tests/test_aggregation.py
index 408cb0822249..4848e94b95b8 100644
--- a/ibis/backends/tests/test_aggregation.py
+++ b/ibis/backends/tests/test_aggregation.py
@@ -495,15 +495,7 @@ def mean_and_std(v):
             id="collect",
             marks=[
                 mark.notimpl(
-                    [
-                        "dask",
-                        "impala",
-                        "mysql",
-                        "snowflake",
-                        "sqlite",
-                        "datafusion",
-                        "mssql",
-                    ]
+                    ["dask", "impala", "mysql", "sqlite", "datafusion", "mssql"]
                 )
             ],
         ),