Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mssql): ensure that dot-sql can be executed when column names are not provided #10028

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Sep 5, 2024

Closes #10025.

@cpcloud cpcloud added bug Incorrect behavior inside of ibis mssql The Microsoft SQL Server backend labels Sep 5, 2024
@cpcloud cpcloud force-pushed the mssql-unnamed-dot-sql branch from 95f666a to e8d33da Compare September 5, 2024 12:42
@cpcloud cpcloud requested review from jcrist and gforsyth September 5, 2024 12:42
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet!

@gforsyth gforsyth enabled auto-merge (squash) September 5, 2024 15:29
@gforsyth gforsyth merged commit 1936437 into ibis-project:main Sep 5, 2024
81 checks passed
@cpcloud cpcloud deleted the mssql-unnamed-dot-sql branch September 5, 2024 15:35
@cpcloud cpcloud added this to the 9.5 milestone Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis mssql The Microsoft SQL Server backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ibis can't handle response from mssql when statement is CAST('2024-01-01 00:00:00' AS DATETIMEOFFSET)
2 participants