Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api): deprecate to_array in favor of as_scalar in docstring #10508

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

IndexSeek
Copy link
Member

Description of changes

While reviewing the remaining table expression methods that needed examples, I noticed that to_array did not include the deprecation docstring. The added deprecation note is similar to that of dropna and relabel.

Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@gforsyth gforsyth enabled auto-merge (squash) November 18, 2024 23:05
@gforsyth
Copy link
Member

Flaky CI run, this is good to go. Merging!

@gforsyth gforsyth merged commit 62e8b6c into ibis-project:main Nov 18, 2024
74 of 75 checks passed
@IndexSeek IndexSeek deleted the docs-depr-to_array branch November 18, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants