fix: execute materialized joins in the pandas and dask backends #3086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
dask
jreback
reviewed
Oct 21, 2021
|
@jreback can you approve? |
jreback
reviewed
Oct 21, 2021
| @@ -12,6 +12,7 @@ Release Notes | |||
| These release notes are for versions of ibis **1.0 and later**. Release | |||
| notes for pre-1.0 versions of ibis can be found at :doc:`release-pre-1.0` | |||
|
|
|||
| * :bug:`3086` Error when trying to join tables with Pandas backend | |||
There was a problem hiding this comment.
we should prob put a version tag here (to differeniate the releases). but can be another issue.
There was a problem hiding this comment.
I believe this is automatically done by the plugin
jreback
approved these changes
Oct 21, 2021
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a dispatch to the pandas and dask backends for
ops.MaterializedJoin.This operation is a no-op in those backends, because its child (an
ops.Join) hasalready been evaluated.
Fixes #3082.