feat(ci): More readable workflow job titles #3111
Conversation
|
Seems fine, though the main reason maybe not to rename is now maybe it's more difficult to find the job in the YAML corresponding to the pretty name in the GHA UI? There's probably a way to do that though, and these job names do look much better. |
| os: | ||
| - ubuntu-latest | ||
| - windows-latest | ||
| python-version: |
There was a problem hiding this comment.
This should include 3.8, right? There is a job running windows-py38, but it's actually showing up in the Backends workflow instead of this one.
There was a problem hiding this comment.
And possibly 3.10 too. Though I'm not sure whether we need the extensive OS parametrization.
There was a problem hiding this comment.
We already have 48 builds which seems to be a bit overwhelming.
There was a problem hiding this comment.
🤷 The number of builds that is overwhelming will vary with people. The builds finish relatively quickly given the extent of testing being done. I get what you're saying but I guess I'm more inclined to add tooling (hopefully in the form of a GitHub action, e.g., the test report) to make large build matrices manageable as opposed to cutting out tests to do so.
There was a problem hiding this comment.
FWIW, Cutting out 3.8 is probably fine, unless there are concerns about 3.8 specific bugs that would show up in our builds.
There was a problem hiding this comment.
My comment here was also about the fact that there is a 3.8 build for Windows, but it's showing up in Backends in the UI and not in the Ibis workflow.
There was a problem hiding this comment.
That build seems to belong to the HDF5 backend, fixing.
kszucs
changed the title
kszucs
force-pushed
the
workflow-titles
branch
from
99d4661 to
c29df0a
Compare
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
No description provided.