Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datatypes): infer bytes literal as binary #2915 #3124

Merged
merged 1 commit into from
Nov 19, 2021
Merged

fix(datatypes): infer bytes literal as binary #2915 #3124

merged 1 commit into from
Nov 19, 2021

Conversation

saulpw
Copy link
Contributor

@saulpw saulpw commented Nov 18, 2021 •
edited by cpcloud
Loading

Closes #2915

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2021 •
edited
Loading

Unit Test Results

       38 files         38 suites   1h 19m 8s ⏱️
  7 241 tests   5 441 ✔️ 1 800 💤 0 ❌
29 251 runs  22 147 ✔️ 7 104 💤 0 ❌

Results for commit 887efbd.

♻️ This comment has been updated with latest results.

cpcloud
cpcloud approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging. Thanks!

@cpcloud cpcloud merged commit 887efbd into ibis-project:master Nov 19, 2021
@saulpw saulpw deleted the pw21_inferbytes branch December 6, 2021 22:46
@ibis-project-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Binary literals' type is not inferred
2 participants
@saulpw @cpcloud