-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(literal): allow creating ibis literal with uuid #3131
Conversation
``` import ibis import uuid value = uuid.uuid4() x = ibis.literal(value, type="uuid") ```
for more information, see https://pre-commit.ci
Fixes #3130 |
@gforsyth I think you need to put the issue in the PR description otherwise GH won't pick it up for autoclosing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Yeah, I hadn't seen the issue when I opened it and I don't think github picks up the autoclose if it gets edited into the PR description after the fact. I'll add it in just for the sake of summarization |
Oh good, I was wrong! |
``` import ibis import uuid value = uuid.uuid4() x = ibis.literal(value, type="uuid") ```
e432f42
to
ad088b6
Compare
🎉 This PR is included in version 2.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This was raising
but
ibis.literal(str(value), type="uuid")
wasn't. Adding inuuid.UUID
as a validinstance_of
ruleFixes #3130