Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore the ability to have more than two option levels #3151

Merged
merged 2 commits into from
Dec 9, 2021

Conversation

gerrymanoim
Copy link
Contributor

Closes #3145

Adds a basic test of reading/writing options.

@pep8speaks
Copy link

pep8speaks commented Dec 9, 2021

Hello @gerrymanoim! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-12-09 16:05:56 UTC

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2021

Unit Test Results

       38 files         38 suites   1h 12m 43s ⏱️
  7 241 tests   5 441 ✔️ 1 800 💤 0
29 251 runs  22 147 ✔️ 7 104 💤 0

Results for commit fb4a944.

♻️ This comment has been updated with latest results.

@jreback jreback added the compatibility Compatibility related issues or PRs label Dec 9, 2021
@jreback jreback added this to the 2.x milestone Dec 9, 2021
@jreback
Copy link
Contributor

jreback commented Dec 9, 2021

great can you add a release note and ping on green

Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this.

@cpcloud cpcloud changed the title Restore the ability to have more than two option levels fix: restore the ability to have more than two option levels Dec 9, 2021
@cpcloud cpcloud merged commit fb4a944 into ibis-project:master Dec 9, 2021
@gerrymanoim gerrymanoim deleted the multi-level-options branch December 9, 2021 19:08
@ibis-project-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Compatibility related issues or PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option keys cannot have more than 2 levels?
4 participants