Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support SQL Server flags for self-signed SSL certificates #6640

Closed
1 task done
edrogers opened this issue Jul 15, 2023 · 3 comments
Closed
1 task done

feat: Support SQL Server flags for self-signed SSL certificates #6640

edrogers opened this issue Jul 15, 2023 · 3 comments
Labels
feature Features or general enhancements mssql The Microsoft SQL Server backend
Milestone

Comments

@edrogers
Copy link

Is your feature request related to a problem?

I need to connect to SQL Server being hosted with self-signed SSL certificates. ODBC (and by extension PyODBC) supports this option with some flags. In PyODBC, a connection string might look like:

conn_str = (
    f"Driver={driver};"
    f"Server={server};"
    f"Database={database};"
    "Trusted_Connection=yes;"
    "TrustServerCertificate=yes;"
)

AFAICT, pymssql does not support this functionality

Describe the solution you'd like

A PyODBC implementation would be great 🤞 😅

What version of ibis are you running?

6.0.0

What backend(s) are you using, if any?

MSSQL

Code of Conduct

  • I agree to follow this project's Code of Conduct
@edrogers edrogers added the feature Features or general enhancements label Jul 15, 2023
@gforsyth
Copy link
Member

Thanks for opening this @edrogers and for providing us with the keyword arguments needed to connect to your SQL Server!

I've looked over the documentation for pymssql and I'm pretty sure that there is no way to pass this information to SQL Server using pymssql.

In https://pymssql.readthedocs.io/en/stable/ref/_mssql.html#_mssql.MSSQLConnection there is an option for conn_properties but this is a raw SQL string that is executed immediately after connecting, so can't be used to specify authentication options.

I think this is one more reason for us to investigate adding an option to connect using pyodbc.

xref #6306

@cpcloud
Copy link
Member

cpcloud commented Dec 23, 2023

@edrogers Is this still an issue for you on master? We cut over to using pyodbc for the mssql backend.

@cpcloud cpcloud added the mssql The Microsoft SQL Server backend label Dec 23, 2023
@cpcloud cpcloud added this to the 8.0 milestone Dec 23, 2023
@cpcloud
Copy link
Member

cpcloud commented Dec 23, 2023

We support the query argument to the sqlalchemy pyodbc mssql dialect, so I'm going to close this out.

Thanks for the report!

@cpcloud cpcloud closed this as completed Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features or general enhancements mssql The Microsoft SQL Server backend
Projects
Archived in project
Development

No branches or pull requests

3 participants