Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repr): default to pa.binary for all geospatial dtypes #7817

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

gforsyth
Copy link
Member

Does what it says on the tin. We will want to specialize this more once we have
proper support for geoarrow and friends, but for now, we should assume all
geospatial types should be rendered as binary.

@cpcloud cpcloud added this to the 8.0 milestone Dec 20, 2023
Copy link
Contributor

@ncclementi ncclementi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gforsyth LGTM!

@cpcloud cpcloud added bug Incorrect behavior inside of ibis geospatial Geospatial related functionality labels Dec 20, 2023
@cpcloud cpcloud enabled auto-merge (squash) December 20, 2023 19:03
@cpcloud cpcloud merged commit 066d3fc into ibis-project:master Dec 20, 2023
81 checks passed
@gforsyth gforsyth deleted the pyarrow_repr_geospatial branch December 20, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis geospatial Geospatial related functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants