feat(flink): implement struct field, clean up literal, and adjust timecontext test markers #7997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would avoid going deep on timecontext for now. It's not a well-supported feature. |
mfatihaktas
force-pushed
the
flink/deep-dive-on-test_timecontext-on-main
branch
from
2046c7e to
51924c9
Compare
Thanks for the note. This change consists of only one new operator |
mfatihaktas
force-pushed
the
flink/deep-dive-on-test_timecontext-on-main
branch
from
51924c9 to
5a4299b
Compare
|
@mfatihaktas Yep, thanks for clarifying. I'll adjust the PR title, then this is good to go. |
cpcloud
changed the title
test_window/timecontext.py
cpcloud
approved these changes
Jan 18, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR is a part of the deep-dive investigation to increase the test coverage for Flink backend. Contains the changes made to clear as many of the tests in
test_window.pyandtime_timecontext.pyas possible at this time for the Flink backend.