-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(geospatial): add examples for duckdb supported methods #8128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for churning through this!
Can you also apply ruff format .
? The version of ruff
listed in pyproject.toml
should automatically format the code in docstrings.
The failures I'm seeing are weird, because the expected and the result match. This is only happening for the operations that return geometries. The only difference I see is that the result seems to be truncated shorter than the expected value. But I'm not sure if that can be the problem. |
It's a character-by-character check, so having the results displayed in fewer columns will break the doctests |
@gforsyth ok, this makes sense, but I'm using whatever is the default but what gets produced on my end but that doesn't seem to match whatever CI is producing. |
yeah, it's frustrating. The output gets resized depending on terminal width, so I would recommend narrowing your terminal (and then making note of how many columns you want the output to take up) |
The github actions terminal is set to an 80 character width. Might be possible to change that, but for now, I would just set your terminal to that for generating the doctest outputs |
Ok getting closer. |
I think this is ready for a final look, got to render the EDIT:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SWEET 🚢 it!
This is ready for final review. We'll solve/discuss the literals issue #8143 in a separate PR. |
Description of changes
Issues closed
Closes #7959
TODO/Problems/need help
st_aswkb()
to arrow duckdb/duckdb-spatial#236)point
(which is in numeric types)LineStrings
and the zones example doesn't contain such type of geometry.