-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): support Deferreds in Array.map and .filter #8267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together!
Bit of feedback around tests, and the general approach looks good.
Thanks for the review @cpcloud ! I think I found a fragility with how we generate argument names for the lambdas in SQL. Waiting to here your suggestions on how to fix that, I'm not familiar with the reasoning behind how to generate those arg names. Can we just do |
Certainly possible! We're generating names to workaround an issue in DuckDB (opened by you in #7676 😄, fixed in #7741). I reported this upstream here: duckdb/duckdb#9981 and the fixed was merged 3 weeks ago in duckdb/duckdb#10150. I think DuckDB is the only backend that had this problem, so when DuckDB releases a format-stable version we can bump its version lower bound and remove the workaround. |
This is in prep for adding in Deferreds
4b9201e
to
6a523bd
Compare
6a523bd
to
31bb0dd
Compare
Clouds are passing array tests:
|
Thanks @NickCrews! |
fixes #8180