fix(pyarrow): support accepting pyarrow dictionary types as inputs #8276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
bug
cpcloud
approved these changes
Feb 8, 2024
|
Thank you! |
|
I would possibly a good idea to have a dictionary type in ibis since many of the backends support dictionary/enum/lowcardinality types. |
|
I don't particularly like the idea of that type in ibis, because whether a type is encoded as a dictionary or any other specific way has no effect on the expression API. Since this type is useful in DDL, perhaps there's a way we can have a set of expanded DDL-only types? |
cpcloud
pushed a commit
to cpcloud/ibis
that referenced
this pull request
Feb 12, 2024
cpcloud
pushed a commit
that referenced
this pull request
Feb 12, 2024
cpcloud
pushed a commit
to cpcloud/ibis
that referenced
this pull request
Feb 12, 2024
cpcloud
pushed a commit
that referenced
this pull request
Feb 12, 2024
kszucs
pushed a commit
that referenced
this pull request
Feb 12, 2024
ncclementi
pushed a commit
to ncclementi/ibis
that referenced
this pull request
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8207.