Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mssql): add datatype mapping for hierarchyid #8397

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

gforsyth
Copy link
Member

Description of changes

See https://learn.microsoft.com/en-us/sql/relational-databases/hierarchical-data-sql-server?view=sql-server-ver16
for reference.

We represent this as a string column internally in Ibis (this seems to
be the recommended thing to do by MSSQL itself).

Issues closed

Resolves #8381

See https://learn.microsoft.com/en-us/sql/relational-databases/hierarchical-data-sql-server?view=sql-server-ver16
for reference.

We represent this as a string column internally in Ibis (this seems to
be the recommended thing to do by MSSQL itself).
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we don't have a specific API for this type this seems like the best place to start.

@cpcloud cpcloud added the feature Features or general enhancements label Feb 20, 2024
@cpcloud
Copy link
Member

cpcloud commented Feb 20, 2024

If someone needs to access methods on hierarchyid types, then table_expr.sql(...) is the way to do that.

@cpcloud cpcloud added this to the 9.0 milestone Feb 20, 2024
@cpcloud cpcloud enabled auto-merge (squash) February 20, 2024 16:05
@cpcloud cpcloud added the mssql The Microsoft SQL Server backend label Feb 20, 2024
@cpcloud cpcloud merged commit 2fd2c30 into ibis-project:main Feb 20, 2024
78 checks passed
@gforsyth gforsyth deleted the mssql/hierarchyid branch February 20, 2024 16:41
ncclementi pushed a commit to ncclementi/ibis that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features or general enhancements mssql The Microsoft SQL Server backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: SQL Server Hierarchical Column Support
2 participants