Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(backend-api): remove the database() API and implementation #8406

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Feb 21, 2024

Remove the BaseBackend.database() API. This has been deprecated for a quite a while. Depends on #8405.

@cpcloud cpcloud added this to the 9.0 milestone Feb 21, 2024
@cpcloud cpcloud added the refactor Issues or PRs related to refactoring the codebase label Feb 21, 2024
@cpcloud cpcloud requested a review from gforsyth February 21, 2024 14:09
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but we should wait until #8405 is in (just waiting on CI there)

BREAKING CHANGE: The `BaseBackend.database()` is now removed. Use `con.tables` for accessing tables through an object, and equivalent methods on the `BaseBackend` for methods that were on `Database`.
@gforsyth gforsyth enabled auto-merge (squash) February 21, 2024 19:18
@gforsyth gforsyth merged commit ff5d078 into ibis-project:main Feb 21, 2024
81 checks passed
@cpcloud cpcloud deleted the remove-database branch February 21, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues or PRs related to refactoring the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants