Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flink): add map support #8425

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

mfatihaktas
Copy link
Contributor

@mfatihaktas mfatihaktas commented Feb 22, 2024

Description of changes

Adds MAP support for Flink backend. Addresses item 9 in #8250.

@cpcloud cpcloud added this to the 9.0 milestone Feb 23, 2024
@cpcloud cpcloud added feature Features or general enhancements flink Issues or PRs related to Flink labels Feb 23, 2024
@cpcloud cpcloud marked this pull request as ready for review February 23, 2024 20:09
Copy link
Contributor Author

@mfatihaktas mfatihaktas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cpcloud! It looks great. I am happy that the ugly override of datatype_sql was not necessary.

@mfatihaktas mfatihaktas self-assigned this Feb 23, 2024
@cpcloud cpcloud force-pushed the feat/flink/map-support branch from ac20e5d to ce15e5f Compare February 24, 2024 13:38
@cpcloud cpcloud enabled auto-merge (squash) February 24, 2024 13:41
@cpcloud cpcloud merged commit 68739a2 into ibis-project:main Feb 24, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features or general enhancements flink Issues or PRs related to Flink
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants