-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(postgres): fix json type conversion in to_pyarrow
output
#8439
Conversation
ACTION NEEDED Ibis follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
to_pyarrow
output
7009f3c
to
8b0900f
Compare
89bb386
to
ae21232
Compare
I localized the pyarrow json type to the snowflake backend to preserve the pretty printing of array/map/struct types. |
ae21232
to
bc3f809
Compare
7be7895
to
c28e103
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Localize custom pyarrow json serialization to snowflake. This custom type doesn't compose well (e.g., inside structs, which aren't directly supported in snowflake anyway) and was causing problems for other backends when trying to convert rows into a struct of the table schema and then into a proper table.
Fixes #8318.