Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphviz): show proper field attributes of accessed relations and do not display join link property accesses #8521

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Mar 2, 2024

This PR properly displays relation field names when accessed and avoids displaying references as .None when coming from a JoinLink object.

@cpcloud cpcloud added this to the 9.0 milestone Mar 2, 2024
@cpcloud cpcloud added bug Incorrect behavior inside of ibis ux User experience related issues labels Mar 2, 2024
@cpcloud cpcloud force-pushed the fix-relations-graphviz branch from 1d4ace7 to 9d7b104 Compare March 19, 2024 11:24
@cpcloud cpcloud requested a review from kszucs March 19, 2024 12:02
@cpcloud
Copy link
Member Author

cpcloud commented Mar 22, 2024

Going to merge this.

@cpcloud cpcloud merged commit 69d6c73 into ibis-project:main Mar 22, 2024
92 checks passed
@cpcloud cpcloud deleted the fix-relations-graphviz branch March 22, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis ux User experience related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant