Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): support variadic arguments on Table.group_by() #8546

Merged
merged 1 commit into from
Mar 5, 2024
Merged

feat(api): support variadic arguments on Table.group_by() #8546

merged 1 commit into from
Mar 5, 2024

Conversation

NickCrews
Copy link
Contributor

Fixes #8504

cpcloud
cpcloud approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@cpcloud cpcloud changed the title feat: support nargs on Table.group_by() feat(api): support variadic arguments on Table.group_by() Mar 5, 2024
@cpcloud cpcloud added the ux User experience related issues label Mar 5, 2024
@cpcloud cpcloud added this to the 9.0 milestone Mar 5, 2024
@cpcloud cpcloud merged commit 665bc4f into ibis-project:main Mar 5, 2024
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kszucs kszucs kszucs left review comments

@cpcloud cpcloud cpcloud approved these changes

Assignees
No one assigned
Labels
ux User experience related issues
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.

feat: support Table.group_by(*keys)
3 participants
@NickCrews @cpcloud @kszucs