-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add concepts guide on Datatypes and Datashapes #8557
Conversation
a48078b
to
3de8312
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick pass, but this is really nice @NickCrews -- thanks for putting it together! I've flagged a few typos and some styling nits, nothing major.
I do think that most of the code examples can be made executable (I'm not sure about the one that raises the RelationError
...)
I would make the code blocks runnable; use a |
You can also set |
e41adc7
to
94ae57c
Compare
94ae57c
to
fb53cc3
Compare
Thanks for all the thoughts! I agree with all of them. Two lingering thoughts:
|
fb53cc3
to
44011da
Compare
44011da
to
3445474
Compare
I think this is ok to ignore -- if you wanted to be explicit and make sure it's covered, I think I would introduce it in a callout note and say something like (unpolished):
I liked it and I think it's a good balance of a word that will both communicate the idea to readers less familiar with datatypes but still correct enough for more familiar readers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can go in, but I'll hold off on merging in case you have any other tweaks you'd like to make @NickCrews . Thanks again for putting this together!
Thanks for the reviews! This looks good to me, merge it! |
Gah, definitely meant to get in a review of this, but it was minor so I'll just put up a PR to change. |
Quick follow-up to #8557. Changes the name of datatypes_datashapes.qmd to just datatypes to simplify the url.
inspired by #8358