feat(geospatial): add support for duckdb operations on literals #8570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncclementi
force-pushed
the
geo-literals-ddb
branch
from
d139018 to
d7e8157
Compare
jcrist
reviewed
Mar 6, 2024
jcrist
reviewed
Mar 6, 2024
ncclementi
force-pushed
the
geo-literals-ddb
branch
2 times, most recently
from
a2df0fa to
6584523
Compare
jcrist
reviewed
Mar 7, 2024
cpcloud
approved these changes
Mar 7, 2024
cpcloud
added
feature
|
Just in case, Don't merge yet. I'll take care of Jim's comment about the |
ncclementi
force-pushed
the
geo-literals-ddb
branch
3 times, most recently
from
d8cdb59 to
dde5b2e
Compare
ncclementi
force-pushed
the
geo-literals-ddb
branch
from
dde5b2e to
cad5f75
Compare
|
This one is ready to go/ ready for the last review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR add support for duckdb geospatial operations directly on geospatial literals.
I gave this a try, I'm not sure this is the best way to go, but happy to iterate over it if there is a better way around.
Issues closed
Closes: #8143
cc: @gforsyth (thanks for the pointer to
_run_pre_execute_hooks)